Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: Deploy to Heroku on PR merge #2299

Closed
wants to merge 1 commit into from
Closed

patch: Deploy to Heroku on PR merge #2299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/deploy-to-heroku.yml
View file
Open in desktop
@@ -1,15 +1,16 @@
name: Deploy to Heroku

on:
push:
branches:
- master
pull_request:
types:
- closed
# Deploys to Heroku once each day
schedule:
- cron: "0 0 * * *"

jobs:
build:
if_merged:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipulgupta2048 , you may as well remove the cron schedule above if we're going to have this condition. This makes sure that only changes from merges are acted on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @cmfcruz Will close this out. Thanks for the review.

if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
environment: balena-docs
steps:
Expand Down