Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Browserify to not include absolute paths in final bundle #1429

Closed
jviotti opened this issue May 15, 2017 · 0 comments · Fixed by #1449
Closed

Patch Browserify to not include absolute paths in final bundle #1429

jviotti opened this issue May 15, 2017 · 0 comments · Fixed by #1449
Labels
component:cli platform:all type:bug
Milestone
1.1

Comments

@jviotti
Copy link
Contributor

jviotti commented May 15, 2017

See #1409
@jviotti jviotti added this to the Post 1.0 Housekeeping milestone May 15, 2017
@jviotti jviotti mentioned this issue May 17, 2017
Merged
jviotti pushed a commit that referenced this issue May 17, 2017
fix(CLI): get rid of Browserify absolute path workaround
23e5a0a 
We encountered a Browserify bug when releasing the CLI, where absolute
paths would be hard-coded in the final bundle. Since we were in the
middle of a release process, we added a quick and dirty
search-and-replace workaround on `concatenate-javascript.sh`.

After the release, we submitted a PR to Browserify which fixes the
issue. This commit makes use of my personal fork to be able to use such
fix while it gets merged to the main project.

See: browserify/browserify#1725
See: #1409
Fixes: #1429
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
@jviotti jviotti mentioned this issue May 17, 2017
Merged
jviotti pushed a commit that referenced this issue May 22, 2017
fix(CLI): get rid of Browserify absolute path workaround
0179813 
We encountered a Browserify bug when releasing the CLI, where absolute
paths would be hard-coded in the final bundle. Since we were in the
middle of a release process, we added a quick and dirty
search-and-replace workaround on `concatenate-javascript.sh`.

After the release, we submitted a PR to Browserify which fixes the
issue. This commit makes use of my personal fork to be able to use such
fix while it gets merged to the main project.

See: browserify/browserify#1725
See: #1409
Fixes: #1429
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
jviotti pushed a commit that referenced this issue May 22, 2017
fix(CLI): get rid of Browserify absolute path workaround (#1449)
8e681b5 
We encountered a Browserify bug when releasing the CLI, where absolute
paths would be hard-coded in the final bundle. Since we were in the
middle of a release process, we added a quick and dirty
search-and-replace workaround on `concatenate-javascript.sh`.

After the release, we submitted a PR to Browserify which fixes the
issue. This commit makes use of my personal fork to be able to use such
fix while it gets merged to the main project.

See: browserify/browserify#1725
See: #1409
Fixes: #1429
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:cli platform:all type:bug
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

fix(CLI): get rid of Browserify absolute path workaround balena-io/etcher
1 participant
@jviotti