upgrade: drivelist to v5.0.25 #1574
Conversation
|
This commit still references a drivelist unmerged branch. I'll update it once the new version is released to npm. |
|
This will also include balena-io-modules/drivelist#191 if I'm not mistaken, fixing #1571 – @jviotti do you want to add that to the commit message as well? |
|
Oh, right, I'll add it. |
jviotti
force-pushed
the
upgrade-drivelist
branch
2 times, most recently
from
65c1c38
to
c2243d8
Compare
|
This PR has now been updated to point to a version at npm. |
jviotti
force-pushed
the
upgrade-drivelist
branch
from
c2243d8
to
98683eb
Compare
| @@ -22,6 +22,10 @@ const path = require('path'); | |||
| const EXIT_CODES = require('../shared/exit-codes'); | |||
| let mainWindow = null; | |||
|
|
|||
| // Enable drivelist debugging information | |||
There was a problem hiding this comment.
Probably worth mentioning this in the commit-message too?
This version contains various improvements on the drive detection system mainly on Windows. The improvements can be summarized as follows: - Drivelist no longer spawns a .bat script to perform its job. This means that a lot of spawning related issues are now fixed - Drivelist doesn't fetch drive sizes from WMI anymore, which was known to incorrectly report a very small size for certain drives, causing the famous "0.0 GB" Windows issues (see balena-io-modules/drivelist#142) - Cleanup temporary scripts after execution This PR also sets the DRIVELIST_DEBUG environment variable to enable debug information from Windows' drivelist implementation. Change-Type: patch Changelog-Entry: Implement Windows drive detection using C++ Changelog-Entry: Fix various Windows `.bat` spawning issues Changelog-Entry: Fix 0.0 GB Windows drive detection issues Changelog-Entry: Cleanup drive detection temporary scripts created for other operating systems Fixes: #1108 Fixes: #1054 Fixes: #995 Fixes: #1483 Fixes: #1142 Fixes: #1571 See: https://github.com/resin-io-modules/drivelist/blob/master/CHANGELOG.md Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
upgrade-drivelist
branch
from
98683eb
to
ef6cf52
Compare
|
For anybody affected by any of the issues that this bug closed, you can test out the following builds of Etcher:
|
|
Hello! So I'm having the same issue, when starting up Etcher, the error saying "Couldn't scan the drives" is showing up. |
|
@DarkWolfx Maybe you're also being affected by balena-io-modules/drivelist#198 ? |
This version contains various improvements on the drive detection system
mainly on Windows. The improvements can be summarized as follows:
Drivelist no longer spawns a .bat script to perform its job. This
means that a lot of spawning related issues are now fixed
Drivelist doesn't fetch drive sizes from WMI anymore, which was known
to incorrectly report a very small size for certain drives, causing
the famous "0.0 GB" Windows issues (see
Method of getting drive size on Windows needs changing balena-io-modules/drivelist#142)
Cleanup temporary scripts after execution
This PR also sets the DRIVELIST_DEBUG environment variable to enable
debug information from Windows' drivelist implementation.
Change-Type: patch
Changelog-Entry: Implement Windows drive detection using C++
Changelog-Entry: Fix various Windows
.batspawning issuesChangelog-Entry: Fix 0.0 GB Windows drive detection issues
Changelog-Entry: Cleanup drive detection temporary scripts created for other operating systems
Fixes: #1108
Fixes: #1054
Fixes: #995
Fixes: #1483
Fixes: #1142
Fixes: #1571
See: https://github.com/resin-io-modules/drivelist/blob/master/CHANGELOG.md
Signed-off-by: Juan Cruz Viotti jv@jviotti.com