Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add WoeUSB as an alternative tool to burn Windows USB images #1743

Merged
merged 3 commits into from Feb 9, 2018

Conversation

brlin-tw
Copy link
Contributor

By far it is one of the few applications that support Windows image and runs on GNU/Linux so I assume it is worth to mention it.

Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>

This PR supersedes #1742 to match the current markup

@alecmev
Copy link

alecmev commented Dec 27, 2017

You should mention WoeUSB in lib/shared/messages.js as well.

@brlin-tw
Copy link
Contributor Author

brlin-tw commented Dec 27, 2017

I have modified lib/shared/messages.js to add the requested changes, please review.

EDIT: A forced push is made to comply with the commit message format requirement.

By far WoeUSB is one of the few applications that support Windows image
and runs on GNU/Linux so I assume it is worth to mention it.  Additional
line wrapping is made to comply to the code conventions.

Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
@@ -15,7 +15,7 @@ images, usually available from the image publishers themselves.
Images known to require special treatment:

- Microsoft Windows (use [Windows USB/DVD Download Tool][windows-usb-tool], or
[Rufus][rufus]).
[Rufus][rufus], or [WoeUSB][woeusb]).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the ", or" before the Rufus link? It reads a bit odd otherwise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the comma-space shouldn't be removed?

Copy link
Contributor Author

@brlin-tw brlin-tw Dec 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied the request change (with comma-space kept intact), please review.

Performing requested change, this commit is supposed to be squashed with the previous one.

Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
@jhermsmeier jhermsmeier merged commit 4cd16a4 into balena-io:master Feb 9, 2018
@jhermsmeier
Copy link
Contributor

Hey @Lin-Buo-Ren, sorry it took so long; it went under in between all the other things. I've resolved the conflicts & merged it now.

@brlin-tw brlin-tw deleted the patch-1 branch September 6, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants