I18n conflict resolve #3936
Merged
I18n conflict resolve #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RoderickQiu @mcraa this PR replaces #3790. Please review and approve/merge when ready. |
|
Oh, good, thanks! |
- make i18n using i18next - add Chinese (Simplified) support
- split translations from i18n.ts to several .ts files in lib/gui/app/i18n - make a README for new language changes - add zh-TW instead of only zh-CN
Optimized several translations. This commit itself is only a patch, but as a pull request must have at least one commit with a change-type. Change-Type: minor
more direct string-concatenation, thanks to @lurch
- use `import * as i18next from 'i18next';` instead of `import i18next from 'i18next';` and add an specific env to bypass mocha test - optimized several translations
according to a suggestion of @lurch
Change-type: minor
ab77
force-pushed
the
i18n-conflict-resolve
branch
from
d2827c7
to
8fc574f
Compare
mcraa
suggested changes
Dec 14, 2022
mcraa
approved these changes
Dec 14, 2022
|
thanks again for the effort and patience @RoderickQiu |
|
Hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.