refactor: get rid of electron-packager in GNU/Linux
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to take a whitelisting approach to dependencies, the `unix/dependencies.sh` script is ran as part of packaging as well, but passing the `-p` (production) flag. In the future, the current `install`, `package`, and `installer` targets will be deplaced by `develop-<type>`, `installer-<type>`. Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
|
So, is "rolling our own" a better solution than enhancing the |
|
Yeah, `electron-packager` had many limitations that we were currently
workarounding (like incorrectly setting the binary name for the `*.app`
in OS X, not copying the LICENSE correctly, etc), and we were planning
to get rid of it for quite some time, see
#820 (comment) for
one of the major motivations.
…On Mon, Nov 28, 2016 at 09:21:05AM -0800, Andrew Scheller wrote:
So, is "rolling our own" a better solution than enhancing the `electron-packager` that we _were_ using?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#897 (comment)
--
Juan Cruz Viotti
Software Engineer
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to take a whitelisting approach to dependencies, the
unix/dependencies.shscript is ran as part of packaging as well, butpassing the
-p(production) flag.In the future, the current
install,package, andinstallertargetswill be deplaced by
develop-<type>,installer-<type>.Signed-off-by: Juan Cruz Viotti jviotti@openmailbox.org