device-metrics: create timeseries per-device with device_uuid tag #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xginn8
force-pushed
the
per-device-metrics
branch
3 times, most recently
from
7513f3a
to
c399e9e
Compare
hedss
approved these changes
Aug 14, 2019
xginn8
force-pushed
the
per-device-metrics
branch
2 times, most recently
from
6dfb1a8
to
bc0d9ce
Compare
|
generally inserting label names directly into the metric names is discouraged, however in this case we are covered by the one exception that makes sense (from https://www.robustperception.io/on-the-naming-of-things):
|
xginn8
force-pushed
the
per-device-metrics
branch
2 times, most recently
from
8b8e717
to
4b19552
Compare
xginn8
force-pushed
the
per-device-metrics
branch
2 times, most recently
from
585b756
to
6629775
Compare
xginn8
force-pushed
the
per-device-metrics
branch
from
6629775
to
a4d74cf
Compare
xginn8
force-pushed
the
per-device-metrics
branch
2 times, most recently
from
bc6673e
to
6be4abd
Compare
wrboyce
approved these changes
Oct 21, 2019
Connects-to: https://github.com/balena-io/balena-monitor/pull/94 HQ: https://github.com/balena-io/balena/issues/1869 Change-type: minor Signed-off-by: Matthew McGinn <matthew@balena.io>
xginn8
force-pushed
the
per-device-metrics
branch
from
6be4abd
to
8946c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects-to: https://github.com/balena-io/balena-monitor/pull/94
HQ: https://github.com/balena-io/balena/issues/1869
Change-type: minor
Signed-off-by: Matthew McGinn matthew@balena.io