Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs: Add support for an ACME certificate provider #38

Merged
merged 1 commit into from Mar 8, 2019

Conversation

richbayliss
Copy link
Contributor

Add a service which will acquire certificates from an ACME cert
provider, such as LetsEncrypt (), to allow an openBalena instance
to use a publicly trusted certificate instead of the self-signed
one it wil generate on setup.

Change-type: patch
Signed-off-by: Rich Bayliss rich@balena.io

cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
Copy link
Member

@dfunckt dfunckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @richbayliss !

cert-provider/Dockerfile Show resolved Hide resolved
cert-provider/cert-provider.sh Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
haproxy/entry.sh Outdated Show resolved Hide resolved
compose/services.yml Outdated Show resolved Hide resolved
@richbayliss richbayliss force-pushed the add-acme-support branch 2 times, most recently from cb5415c to abb59ad Compare March 6, 2019 14:10
@richbayliss richbayliss force-pushed the add-acme-support branch 3 times, most recently from 30fd8be to f37d695 Compare March 6, 2019 14:22
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
compose/services.yml Show resolved Hide resolved
compose/services.yml Outdated Show resolved Hide resolved
scripts/make-env Outdated Show resolved Hide resolved
@richbayliss richbayliss force-pushed the add-acme-support branch 2 times, most recently from cf5b1fb to 9a4b4f2 Compare March 7, 2019 13:16
scripts/quickstart Outdated Show resolved Hide resolved
@richbayliss richbayliss requested a review from dfunckt March 7, 2019 14:25
Copy link
Contributor

@wrboyce wrboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only some minor (read: actioning optional) comments this time.

cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
cert-provider/cert-provider.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@wrboyce wrboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

scripts/quickstart Outdated Show resolved Hide resolved
Add a service which will acquire certificates from an ACME cert
provider, such as LetsEncrypt (), to allow an openBalena instance
to use a publicly trusted certificate instead of the self-signed
one it wil generate on setup.

Change-type: patch
Signed-off-by: Rich Bayliss <rich@balena.io>
@richbayliss richbayliss merged commit 0fc85ff into master Mar 8, 2019
@richbayliss richbayliss deleted the add-acme-support branch March 8, 2019 12:29
@bartversluijs
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants