Add async tasks

[joshbwlng]

Change-type: minor

---

Spec: https://balena.fibery.io/Inputs/Research/PineJS-Async-Tasks-483

Testing locally:

docker-compose -f docker-compose.npm-test.yml up -d
export DATABASE_URL=postgres://docker:docker@localhost:5431/postgres
export PINEJS_QUEUE_CONCURRENCY=1
TZ=UTC npm run mocha test/08-tasks.test.ts

[joshbwlng]

Note: I also investigated using zod to define parameter object shapes, but decided to stick with JSON Schema as its a commonly used standard. Consumers can still define their shapes with zod and then convert to JSON Schema using something like zod-to-json-schema when defining task handlers.

[Page-]

Why is the ?. needed? I feel like if it's ever undefined then the entire task system would break and that's not something we'd want to silently ignore

[Page-]

Is this compliant with postgres+mysql+sqlite? If not we should have a warning if you're trying to use with an unsupported db engine

[Page-]

This should be outside of the transaction imo to avoid the unnecessary db interaction. Presumably you've put it inside to be in a promise chain but I think it'd be better to do something like

(async () => {
	try {
		let executed = false;
		const handlerNames = Object.keys(this.handlers);
		const binds = handlerNames.map((_, index) => `$${index + 1}`).join(', ');
		if (!this.canExecute()) {
			return;
		}
		await sbvrUtils.db.transaction(async (tx) => {
			...
		});
	} catch (err) {
		...
	} finally {
		...
	}
})();

to be able to use async/await as usual and put the try/catch/finally around everything

[Page-]

I'm pretty sure this is not doing what you expect as by my calculations this would be setting the minimum delay to a bit over 6 hours (e^10)? I think it probably makes sense to use logic more similar to https://github.com/balena-io-modules/pinejs-client-js/blob/v6.14.6/src/index.ts#L1123 for the next delay time

[joshbwlng]

@Page- My mistake here was * 1000, not sure how I missed it. I didn't come up with the formula myself, I pulled it from graphile/worker: https://worker.graphile.org/docs/exponential-backoff

[Page-]

Suggested change

	},
	body: {
	},
	options: {
	returnResource: false,
	},
	body: {

[Page-]

This should be able to be done by defining and initSql in the model definition the same way as user models would

[Page-]

I assume this is because we only support tasks on postgres, which is fine but should throw an error here rather than silently/surprisingly doing nothing

[Page-]

satisfies is better because it doesn't cast in the same way

Suggested change

	] as sbvrUtils.ExecutableModel[],
	] satisfies sbvrUtils.ExecutableModel[],

although I think it'd be better to use

export const config ConfigLoader.Config = {

so that the whole thing is typed and matches the expectation

[Page-]

Can this be something like pinejs$task_insert to try to namespace it more?

[Page-]

I'd prefer try/catch with await so we can handle both sync/async exceptions, just as additional safety

Suggested change

	client.on(name, (msg) => {
	fn(msg).catch((error) => {
	console.error('Error handling message:', error);
	});
	});
	client.on(name, async (msg) => {
	try {
	await fn(msg);
	} catch (error) {
	console.error('Error handling message:', error);
	}
	});