Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Change BALENA_MACHINE_NAME to BALENA_ARCH in ui/Dockerfile.amd64 #21

Closed
rahul-thakoor opened this issue Apr 20, 2020 · 3 comments
Closed

Change BALENA_MACHINE_NAME to BALENA_ARCH in ui/Dockerfile.amd64 #21

rahul-thakoor opened this issue Apr 20, 2020 · 3 comments
Milestone
0.3.4

Comments

@rahul-thakoor
Copy link
Contributor

No description provided.

@chrisys chrisys added this to the 0.3.4 milestone Apr 20, 2020
@chrisys
Copy link
Member

chrisys commented Apr 21, 2020

@rahul-thakoor could you the add the reasoning here, plus confirm if you mean ARCH_NAME or BALENA_ARCH?

@rahul-thakoor rahul-thakoor changed the title Change BALENA_MACHINE_NAME to ARCH_NAME in ui/Dockerfile.amd64 Change BALENA_MACHINE_NAME to BALENA_ARCH in ui/Dockerfile.amd64 Apr 21, 2020
@rahul-thakoor
Copy link
Contributor Author

hey @chrisys , yes a typo on my part. fixed.

My reasoning is Generic x86_64 is currently using intel-nuc as machine name. If that were to change and the same base images were not available for some reason, the build would fail.

@rahul-thakoor
Copy link
Contributor Author

Also, I think we can consolidate ui/Dockerfile.template and ui/Dockerfile.amd64 into single ui/Dockerfile.template since the only difference seems to be the arch name for downloading gotty which we can infer at build time using BALENA_ARCH

chrisys added a commit that referenced this issue Apr 21, 2020
@chrisys
Update machine name to arch, fixes #21
9ef2437 
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.4
Development

No branches or pull requests
2 participants
@chrisys @rahul-thakoor