This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Add ram settings validation and flags to disable it #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: minor
Change-type: patch
Change-type: patch
Change-type: patch
|
This comment from the related issue is also relevant here |
Change-type: patch
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
chrisys
reviewed
Apr 27, 2020
|
@balena-ci retest |
chrisys
approved these changes
Apr 28, 2020
boinc-client/start.sh
Outdated
| fi | ||
|
|
||
| totalmem=$(awk '/^MemTotal:/{print $2}' /proc/meminfo) | ||
|
|
||
| if [ "$totalmem" -lt "1500000" ]; then | ||
| if [[ -z $SKIP_BOINC_CPU_SETTINGS_CHECK && "$totalmem" -lt "2500000" ]]; then | ||
| echo "Less than 1.5GB RAM - running single concurrent task" |
There was a problem hiding this comment.
I think this should be 2.5GB?
Change-type: patch
|
@balena-ci retest |
rahul-thakoor
approved these changes
Apr 28, 2020
|
+1 thanks for the great contribution @ptrm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
There's also check for
SKIP_BOINC_MEM_SETTINGS_CHECKandSKIP_BOINC_CPU_SETTINGS_CHECKenvironment variables to disable the auto-correction of config values.Adds ca. 5MB to boinc-client image because of adding xml-twig-tools to read config values.