Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default port for API Swagger docs #447

Closed
wants to merge 1 commit into from
Closed

Add default port for API Swagger docs #447

wants to merge 1 commit into from

Conversation

kb2ma
Copy link
Contributor

@kb2ma kb2ma commented Nov 6, 2023

The swagger-docs target to the top level makefile builds the docs and makes them available on localhost port 9000. Add the port number to the README.

@lmbarros
Copy link
Collaborator

lmbarros commented Nov 6, 2023

The ideal would be to try to get this merged upstream and then get the change via a merge or cherry-pick (to avoid diverging from Moby, and thus simplifying merges). Doesn't look like a controversial thing, so I guess this has a reasonable chance of being accepted.

What do you think, @kb2ma ?

@kb2ma
Copy link
Contributor Author

kb2ma commented Nov 6, 2023

I didn't realize this came directly from upstream. Sure, sounds like a worthwhile experiment. Let me first be sure my force-push fixes the error.

Change-type: patch
Signed-off-by: Ken Bannister <kb2ma@runbox.com>
@kb2ma
Copy link
Contributor Author

kb2ma commented Nov 6, 2023

@lmbarros , the build has failed a couple of times now on the "Is custom" check. Have you seen this error before? Any idea on how to fix it?

@lmbarros
Copy link
Collaborator

lmbarros commented Nov 6, 2023

I don't recall seeing this before, @kb2ma . Our last commit on this repo was almost 2 months ago. Maybe a flowzone regression created over this period?

@kb2ma
Copy link
Contributor Author

kb2ma commented Nov 7, 2023

Created moby/moby#46781, so closing this one.

@kb2ma kb2ma closed this Nov 7, 2023
auto-merge was automatically disabled November 7, 2023 13:27

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants