Bugfix: Don't close base images prematurely #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous implementation was closing the base image stream before it was even used. With this commit we make it clear who is responsible for closing this stream, and ensure it is closed only after it's used. Signed-off-by: Leandro Motta Barros <leandro@balena.io> Change-type: patch
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in the refactoring made during the work on Delta on load. The previous implementation was closing the base image stream before it was even used.
This effectively marked layers as no longer locked, which means other concurrent tasks would be able to remove them while they were still needed. So, this PR is very likely to help with #444 -- possibly solving it entirely (though it's hard to test or otherwise confirm this with 100% certainty).
The solution implemented here is simple enough: we make it clear who is responsible for closing this stream, and ensure it is closed only after it's used.