-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakogut/kirkstone (rebased over kirkstone_update) #560
Conversation
afbb783
to
9ed6a3f
Compare
@resin-jenkins retest this please |
@balena-ci rebase |
9ed6a3f
to
025c24b
Compare
025c24b
to
26cc07b
Compare
@balena-ci rebase |
26cc07b
to
29ccdd9
Compare
[alexgg] This has attached https://jel.ly.fish/99c19a05-ea05-4655-a4d7-a047bb001a64 |
IMAGE_INSTALL:append = " efibootmgr" | ||
IMAGE_INSTALL:append = " \ | ||
efibootmgr \ | ||
haveged \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakogut I think this commit needs more explanation. Why is the hardware RNG not working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexgg You're right, this commit could've used more description. I've been trying to get this to pass tests for weeks now, so the context isn't as fresh anymore, but what I remember is that the patch we applied as a workaround no longer applies cleanly. I was hoping to find out if the issue is even present anymore, as well as whether or not haveged could be used to generate extra entropy on boot to work around it so we could drop the patch entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To push this PR getting merged let's merge it without haveged installed and we'll see after. As Alex said, we already have rngd which is responsible for entropy generation but the problem might be different iirc.
@resin-jenkins retest this please |
0f7432c
to
b434bb4
Compare
b434bb4
to
11a97bc
Compare
9ef115a
to
58e8c0a
Compare
@resin-jenkins test this please |
@resin-jenkins retest this please |
[alexgg] This has attached https://jel.ly.fish/15edef4c-8b0a-4fae-b348-d86018b3aa24 |
58e8c0a
to
a6ae586
Compare
This is now replaced by meta-balena/meta-balena-rust Signed-off-by: Florin Sarbu <florin@balena.io>
Changelog-entry: Update to kirkstone-4.0.3 Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
We will rely on the one from Poky instead Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Joseph Kogut <joseph@balena.io>
Previously, we bundled efivar v37 to fix a known issue with provisioning the Surface Go using older versions. Revert to the upstream recipe in poky, which is newer. Signed-off-by: Joseph Kogut <joseph@balena.io>
Signed-off-by: Joseph Kogut <joseph@balena.io>
a6ae586
to
5006eb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@floion
A few more fixes in this branch, though I'm still working on getting the build to succeed. Feel free to pull these changes into your branch if you wish.I think the build is fixed at this point, we'll see if it passes CI.