Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakogut/kirkstone (rebased over kirkstone_update) #560

Merged
9 commits merged into from
Nov 2, 2022
Merged

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Sep 27, 2022

@floion A few more fixes in this branch, though I'm still working on getting the build to succeed. Feel free to pull these changes into your branch if you wish.

I think the build is fixed at this point, we'll see if it passes CI.

@jakogut
Copy link
Contributor Author

jakogut commented Oct 4, 2022

@resin-jenkins retest this please

@alexgg
Copy link
Contributor

alexgg commented Oct 13, 2022

@balena-ci rebase

@alexgg alexgg changed the title Jakogut/kirkstone Jakogut/kirkstone (rebased over kirkstone_update) Oct 13, 2022
@alexgg
Copy link
Contributor

alexgg commented Oct 13, 2022

@balena-ci rebase

@jellyfish-bot
Copy link

[alexgg] This has attached https://jel.ly.fish/99c19a05-ea05-4655-a4d7-a047bb001a64

IMAGE_INSTALL:append = " efibootmgr"
IMAGE_INSTALL:append = " \
efibootmgr \
haveged \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakogut I think this commit needs more explanation. Why is the hardware RNG not working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgg You're right, this commit could've used more description. I've been trying to get this to pass tests for weeks now, so the context isn't as fresh anymore, but what I remember is that the patch we applied as a workaround no longer applies cleanly. I was hoping to find out if the issue is even present anymore, as well as whether or not haveged could be used to generate extra entropy on boot to work around it so we could drop the patch entirely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To push this PR getting merged let's merge it without haveged installed and we'll see after. As Alex said, we already have rngd which is responsible for entropy generation but the problem might be different iirc.

@jakogut
Copy link
Contributor Author

jakogut commented Oct 14, 2022

@resin-jenkins retest this please

@floion floion force-pushed the jakogut/kirkstone branch 2 times, most recently from 0f7432c to b434bb4 Compare October 19, 2022 08:26
@floion floion mentioned this pull request Oct 19, 2022
@floion floion force-pushed the jakogut/kirkstone branch 2 times, most recently from 9ef115a to 58e8c0a Compare October 24, 2022 08:01
@floion
Copy link
Contributor

floion commented Oct 24, 2022

@resin-jenkins test this please

@jakogut
Copy link
Contributor Author

jakogut commented Oct 26, 2022

@resin-jenkins retest this please

@jellyfish-bot
Copy link

[alexgg] This has attached https://jel.ly.fish/15edef4c-8b0a-4fae-b348-d86018b3aa24

This is now replaced by meta-balena/meta-balena-rust

Signed-off-by: Florin Sarbu <florin@balena.io>
Changelog-entry: Update to kirkstone-4.0.3
Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
floion and others added 5 commits November 1, 2022 16:48
We will rely on the one from Poky instead

Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Florin Sarbu <florin@balena.io>
Signed-off-by: Joseph Kogut <joseph@balena.io>
Previously, we bundled efivar v37 to fix a known issue with
provisioning the Surface Go using older versions. Revert to the upstream
recipe in poky, which is newer.

Signed-off-by: Joseph Kogut <joseph@balena.io>
Signed-off-by: Joseph Kogut <joseph@balena.io>
Copy link
Contributor

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost merged commit fc78f6a into master Nov 2, 2022
@ghost ghost deleted the jakogut/kirkstone branch November 2, 2022 15:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants