Merge pull request #191 from resin-io/188-use-docker-build-arg

dind: use --parse-arg to change dropbear config during build-time
balena-os · Jul 5, 2016 · 59cf4fd · 59cf4fd
2 parents c4f84e6 + aff199f
commit 59cf4fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -74,8 +74,7 @@ clean:
 	-rm Dockerfile
 
 supervisor-dind:
-	sed -i 's/\(ENV PASSWORDLESS_DROPBEAR\).*/\1 ${PASSWORDLESS_DROPBEAR}/' tools/dind/Dockerfile
-	cd tools/dind && docker build $(DOCKER_HTTP_PROXY) $(DOCKER_HTTPS_PROXY) --no-cache=$(DISABLE_CACHE) -t resin/resin-supervisor-dind:$(SUPERVISOR_VERSION) .
+	cd tools/dind && docker build $(DOCKER_HTTP_PROXY) $(DOCKER_HTTPS_PROXY) --no-cache=$(DISABLE_CACHE) --build-arg PASSWORDLESS_DROPBEAR=$(PASSWORDLESS_DROPBEAR) -t resin/resin-supervisor-dind:$(SUPERVISOR_VERSION) .
 
 run-supervisor: supervisor-dind stop-supervisor
 	cd tools/dind \

diff --git a/tools/dind/Dockerfile b/tools/dind/Dockerfile
@@ -14,7 +14,7 @@ ENV DOCKER_VERSION 1.10.3
 ENV RELEASE_NAME jessie
 
 # Change to 'true' to allow blank password dropbear logins on dind HostOS
-ENV PASSWORDLESS_DROPBEAR false
+ARG PASSWORDLESS_DROPBEAR=false
 
 COPY config/certs/ /usr/local/share/ca-certificates/
 RUN rm -f /usr/local/share/ca-certificates/.keepme ; update-ca-certificates