change registry from docker to bh.cr #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
reviewed
Aug 22, 2023
| @@ -17,4 +17,4 @@ VOLUME /mnt/boot \ | |||
| CMD [ "/entry.sh" ] | |||
|
|
|||
| # avoid display crash on some host systems | |||
| RUN rm /lib/systemd/system/sysinit.target.wants/systemd-udev-trigger.service | |||
| RUN rm /lib/systemd/system/sysinit.target.wants/systemd-udev-trigger.service | |||
There was a problem hiding this comment.
Can you tidy this commit by restoring the empty lines at the end of these files?
This will allow to pull + use newer OS images (> 2.95.12) Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
klutchell
force-pushed
the
ryan/update-registry
branch
from
87d81c0
to
f22cf5b
Compare
klutchell
reviewed
Sep 1, 2023
| @@ -3,7 +3,7 @@ | |||
| ARG OS_VERSION | |||
| ARG DEVICE_TYPE=%%BALENA_MACHINE_NAME%% | |||
|
|
|||
| FROM resin/resinos:${OS_VERSION}-${DEVICE_TYPE} | |||
| FROM bh.cr/balena_os/${DEVICE_TYPE}:${OS_VERSION} | |||
There was a problem hiding this comment.
bh.cr URLS have a / between the app and the version, not a :
|
Superseded by #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to pull + use newer OS images (> 2.95.12)
However as of this moment I haven't been able to get the newer OS images to work on my machine. So leaving at draft for now
Resolves part of #50
Change-type: patch