Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networkmanager 1.40.4 does not include connectivity check? #2964

Closed
everhardt opened this issue Jan 11, 2023 · 3 comments · Fixed by #2968
Closed

Networkmanager 1.40.4 does not include connectivity check? #2964

everhardt opened this issue Jan 11, 2023 · 3 comments · Fixed by #2968

Comments

@everhardt
Copy link

everhardt commented Jan 11, 2023 •
edited

When I run balenaOS 2.108.1 and set the log level for connectivity checking in the NetworkManager to debug (nmcli g log level DEBUG domains CONCHECK), I see the following log lines in journalctl:

Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9106] connectivity: (wwan0,IPv6,38) check completed: FAKE; fake result
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9105] connectivity: (wwan0,IPv4,37) check completed: FAKE; fake result
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9099] connectivity: (eth0,IPv6,24) check completed: FAKE; fake result
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9096] connectivity: (eth0,IPv4,23) check completed: FAKE; fake result
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9090] connectivity: (wwan0,IPv6,38) start fake request (fake result)
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9090] connectivity: (wwan0,IPv4,37) start fake request (fake result)
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9084] connectivity: (eth0,IPv6,24) start fake request (fake result)
Jan 11 11:21:21 27eb737 NetworkManager[1394]: <debug> [1673436081.9084] connectivity: (eth0,IPv4,23) start fake request (fake result)

As balenaOS 2.108.4 includes NetworkManager 1.40.4 (see #2906), these logs come from https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.40.4/src/core/nm-connectivity.c#L1134. Reading the lines above, I think this is caused by the WITH_CONCHECK build flag not being present in the NetworkManager build included in balenaOS.
@everhardt
Copy link
Author

To elaborate: we want to use wwan0 as a failover for eth0. That also did not work in the previous balenaOS release we used (balenaOS 2.98.33), because that one contains a NetworkManager build that suffers from a bug causing hostname resolving to fail on failover connections in case systemd-resolved is not available (which is the case here). See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/57d226d3f08d8a904a554367e799c9c367032b0d for more detail.

@jellyfish-bot
Copy link

[mcraa] This has attached https://jel.ly.fish/a235fd1d-49fb-44bb-aa4f-496d04dbb20b

@majorz
Copy link
Contributor

majorz commented Jan 11, 2023

Thanks for the report and digging into this! As we upgraded to NetworkManager 1.40.4 we had to change the build system to meson and it looks like we missed this option. I will look into this with priority.

majorz added a commit that referenced this issue Jan 12, 2023
@majorz
Enable back connectivity check in NetworkManager
a7a1cd8 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
@majorz majorz mentioned this issue Jan 12, 2023
Merged
6 tasks
majorz added a commit that referenced this issue Jan 12, 2023
@majorz
networkmanager: enable back connectivity check
95efb3f 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 12, 2023
@majorz
networkmanager: enable back connectivity check
02724aa 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 12, 2023
@majorz
networkmanager: enable back connectivity check
7cd7df3 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 13, 2023
@majorz
networkmanager: enable back connectivity check
e5ff0fe 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 13, 2023
@majorz
networkmanager: enable back connectivity check
7e7570d 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 15, 2023
@majorz
networkmanager: enable back connectivity check
9f2a390 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 15, 2023
@majorz
networkmanager: enable back connectivity check
81a7a5f 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 16, 2023
@majorz
networkmanager: enable back connectivity check
f4e164d 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 16, 2023
@majorz
networkmanager: enable back connectivity check
4dda96e 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 17, 2023
@majorz
networkmanager: enable back connectivity check
7d06b0a 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
alexgg pushed a commit that referenced this issue Jan 18, 2023
@majorz @alexgg
networkmanager: enable back connectivity check
0d13d63 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
majorz added a commit that referenced this issue Jan 19, 2023
@majorz
networkmanager: enable back connectivity check
b4ae8c2 
In v2.108.0 we did a major NetworkManager upgrade as we started using
meson as a build system. The connectivity check feature was left
disabled, which is a regression and it produces fake results.

This commit enables it back.

Fixes #2964.

Changelog-entry: Enable back connectivity check in NetworkManager
Change-type: patch
Signed-off-by: Zahari Petkov <zahari@balena.io>
@everhardt everhardt mentioned this issue Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable back connectivity check in NetworkManager balena-os/meta-balena
3 participants
@majorz @everhardt @jellyfish-bot