Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Register teardown only when DUT is reachable #2266

Merged
1 commit merged into from Sep 2, 2021

Conversation

rcooke-warwick
Copy link
Contributor

At the end of the unmanaged OS test suite, we retreive the journal logs from the DUT. If the device is offline, it took a long time to report the error and caused the test job to hang for longer than necessary. This alters the suite by reducing the number of times the testbot retries to retrieve the logs, if it fails to do so

Change-type: patch
Signed-off-by: Ryan Cooke ryan@balena.io


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@resin-jenkins
Copy link

Can one of the admins verify this patch?

@klutchell
Copy link
Collaborator

@resin-jenkins add to whitelist

@klutchell
Copy link
Collaborator

@resin-jenkins retest this please

@klutchell klutchell added this to In Progress in os/tests breakfix Jul 27, 2021
Copy link
Collaborator

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rcooke-warwick
Copy link
Contributor Author

@balena-ci rebase

@ghost ghost force-pushed the ryan/patch-journal-log-fetch branch from 5c10cf4 to 49020e2 Compare August 2, 2021 11:38
@klutchell
Copy link
Collaborator

@balena-ci rebase

@ghost ghost force-pushed the ryan/patch-journal-log-fetch branch from 49020e2 to 7eeb2bc Compare August 6, 2021 11:51
@klutchell
Copy link
Collaborator

@balena-ci rebase

@ghost ghost force-pushed the ryan/patch-journal-log-fetch branch from 7eeb2bc to 6788a85 Compare September 1, 2021 12:52
Change-type: patch
Signed-off-by: Ryan Cooke <ryan@balena.io>
@vipulgupta2048 vipulgupta2048 changed the title tests: save time in teardown when DUT is offline tests: Register teardown only when DUT is reachable Sep 1, 2021
@vipulgupta2048
Copy link
Member

@resin-jenkins retest this please

2 similar comments
@klutchell
Copy link
Collaborator

@resin-jenkins retest this please

@klutchell
Copy link
Collaborator

@resin-jenkins retest this please

@ghost ghost merged commit ee2c756 into master Sep 2, 2021
@ghost ghost deleted the ryan/patch-journal-log-fetch branch September 2, 2021 15:27
@klutchell klutchell moved this from In Progress to Complete in os/tests breakfix May 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants