New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Register teardown only when DUT is reachable #2266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
@resin-jenkins add to whitelist |
@resin-jenkins retest this please |
klutchell
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@balena-ci rebase |
ghost
force-pushed
the
ryan/patch-journal-log-fetch
branch
from
August 2, 2021 11:38
5c10cf4
to
49020e2
Compare
@balena-ci rebase |
ghost
force-pushed
the
ryan/patch-journal-log-fetch
branch
from
August 6, 2021 11:51
49020e2
to
7eeb2bc
Compare
@balena-ci rebase |
ghost
force-pushed
the
ryan/patch-journal-log-fetch
branch
from
September 1, 2021 12:52
7eeb2bc
to
6788a85
Compare
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
vipulgupta2048
force-pushed
the
ryan/patch-journal-log-fetch
branch
from
September 1, 2021 22:54
6788a85
to
2f01b04
Compare
vipulgupta2048
changed the title
tests: save time in teardown when DUT is offline
tests: Register teardown only when DUT is reachable
Sep 1, 2021
vipulgupta2048
approved these changes
Sep 1, 2021
@resin-jenkins retest this please |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the unmanaged OS test suite, we retreive the journal logs from the DUT. If the device is offline, it took a long time to report the error and caused the test job to hang for longer than necessary. This alters the suite by reducing the number of times the testbot retries to retrieve the logs, if it fails to do so
Change-type: patch
Signed-off-by: Ryan Cooke ryan@balena.io
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines