Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packagegroup-resin: Install ldd script in balenaOS images #3396

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Mar 26, 2024

The takeover project currently relies on the ldd script being present in the hostOS pre-migration.

While takeover can be adapted to use this script from a different location, it wouldn't hurt to have ldd in the hostOS from this point on.

Change-type: patch

Related discussion in takeover: balena-os/takeover#66 (comment)


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@flowzone-app flowzone-app bot enabled auto-merge March 26, 2024 15:50
@acostach
Copy link
Contributor Author

amd64 failed with:

| curl: (22) The requested URL returned error: 502
| WARNING: exit code 22 from a shell command.
NOTE: recipe balena-keys-1.0-r0: task do_get_public_keys: Failed

Re-trying

@acostach
Copy link
Contributor Author

@resin-jenkins retest this please

@acostach
Copy link
Contributor Author

acostach commented Apr 1, 2024

@resin-jenkins retest this please

2 similar comments
@acostach
Copy link
Contributor Author

acostach commented Apr 3, 2024

@resin-jenkins retest this please

@acostach
Copy link
Contributor Author

acostach commented Apr 3, 2024

@resin-jenkins retest this please

@acostach acostach force-pushed the acostach/install-ldd-script branch from 37fee33 to 7edef60 Compare April 4, 2024 11:36
@acostach
Copy link
Contributor Author

acostach commented Apr 8, 2024

@resin-jenkins retest this please

2 similar comments
@acostach
Copy link
Contributor Author

acostach commented Apr 9, 2024

@resin-jenkins retest this please

@acostach
Copy link
Contributor Author

@resin-jenkins retest this please

@floion
Copy link
Collaborator

floion commented Apr 11, 2024

@resin-jenkins test this please

1 similar comment
@acostach
Copy link
Contributor Author

@resin-jenkins test this please

The takeover project currently relies on the ldd script being present in the hostOS pre-migration.

While takeover can be adapted to use this script from a different location, it wouldn't hurt to have ldd in the hostOS from this point on.

Change-type: patch
Signed-off-by: Alexandru Costache <alexandru@balena.io>
@acostach acostach force-pushed the acostach/install-ldd-script branch from 7edef60 to 9ef3aea Compare April 16, 2024 15:58
@flowzone-app flowzone-app bot merged commit 2964865 into master Apr 16, 2024
50 checks passed
@flowzone-app flowzone-app bot deleted the acostach/install-ldd-script branch April 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants