Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Tidy up PHP code examples in readme #4

Merged
merged 1 commit into from
Dec 2, 2013

Conversation

rowanhill
Copy link
Contributor

Hi,

Just spotted this library after considering writing something similar myself - looks neat! I haven't had a chance to try it out yet, but I'm looking forward to it.

I just noticed that the PHP code examples in the readme could do with a little love, and since it was so quick to do I thought I'd submit a PR right here and now.

Changes are fairly obvious, but to be explicit, I have:

  • Added PHP syntax highlighting
  • Added missing 'function' keywords
  • Referenced $family instead of the undefined variable $parent (which I assume was the original intent?)
  • Made the spacing consistent (no newlines at the start of classes or functions)

Thanks!
Rowan

@balihoo-cdamour
Copy link
Contributor

thx for the fixes, these apply to https://github.com/balihoo/phockito-unit-php-di too!

balihoo-cdamour added a commit that referenced this pull request Dec 2, 2013
Tidy up PHP code examples in readme
@balihoo-cdamour balihoo-cdamour merged commit 51afd85 into balihoo:master Dec 2, 2013
balihoo-cdamour added a commit to balihoo/phockito-unit-php-di that referenced this pull request Dec 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants