Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit TOML diagnostic model #27044

Open
5 tasks
SupunS opened this issue Nov 20, 2020 · 0 comments
Open
5 tasks

Revisit TOML diagnostic model #27044

SupunS opened this issue Nov 20, 2020 · 0 comments
Labels
Area/TOMLParser TOML parser related issues Priority/High Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/NewFeature

Comments

@SupunS
Copy link
Contributor

SupunS commented Nov 20, 2020

Description:

  • Store diagnostics in each node (not in a single location)
  • Revisit the APIs related to diagnostics
    • Use lists (java.lang.List) for all APIs
    • Returned diagnostics must be ordered.
  • Separate methods to get diagnostic of a given node only, and diagnostics of the entire subtree
  • Add a proper diagnostic logging mechanism (Introduce a proper way to log Toml Validator diagnostics #27041)
  • Fix inconsistencies in method names e.g: addDiagnostics vs addSyntaxDiagnostics() where both does the same thing.
@SupunS SupunS added Area/TOMLParser TOML parser related issues Priority/High labels Nov 20, 2020
@Kishanthan Kishanthan added Team/CompilerFETools Semantic API, Formatter, Shell Type/NewFeature labels Feb 17, 2021
@anupama-pathirage anupama-pathirage added Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) and removed Team/CompilerFETools Semantic API, Formatter, Shell labels Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area/TOMLParser TOML parser related issues Priority/High Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/NewFeature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kishanthan @SupunS @anupama-pathirage