Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell] Const's are not available for /vars #36319

Closed
HirumalPriyashan opened this issue May 25, 2022 · 4 comments · Fixed by #36653
Closed

[Shell] Const's are not available for /vars #36319

HirumalPriyashan opened this issue May 25, 2022 · 4 comments · Fixed by #36653
Assignees
@DamithaSenevirathne
Labels
Area/Shell Issues related to Ballerina Shell CLI tool Points/1 Equivalent to one day effort Points/2 Equivalent to two days effort Reason/Regression The issue has introduced a regression. Team/CompilerFETools Semantic API, Formatter, Shell Type/Bug
Projects
Sprint 57 - Language Server & Compile... Sprint 58 - Language Server & Compile...
Milestone
2201.2.0

Comments

@HirumalPriyashan
Copy link
Contributor

Description:
$subject

Consider the following.
image

Suggested Labels (optional):
Area/Shell
@DamithaSenevirathne DamithaSenevirathne added Team/CompilerFETools Semantic API, Formatter, Shell Area/Shell Issues related to Ballerina Shell CLI tool labels May 25, 2022
@HirumalPriyashan HirumalPriyashan changed the title [Shell] Consts are not available for /vars [Shell] Const's are not available for /vars May 25, 2022
@dulajdilshan dulajdilshan added the Points/2 Equivalent to two days effort label Jun 2, 2022
@dulajdilshan dulajdilshan moved this from Backlog to Plan for This sprint in Sprint 57 - Language Server & Compiler Tools Team Jun 2, 2022
@DamithaSenevirathne DamithaSenevirathne moved this from Plan for This sprint to In progress in Sprint 57 - Language Server & Compiler Tools Team Jun 15, 2022
@mohanvive mohanvive added the Points/1 Equivalent to one day effort label Jun 16, 2022
@mohanvive mohanvive moved this from In progress to Not completed in Sprint 57 - Language Server & Compiler Tools Team Jun 16, 2022
@mohanvive mohanvive moved this from Backlog to Plan for This sprint in Sprint 58 - Language Server & Compiler Tools Team Jun 16, 2022
@DamithaSenevirathne DamithaSenevirathne moved this from Plan for This sprint to In progress in Sprint 58 - Language Server & Compiler Tools Team Jun 17, 2022
@dulajdilshan
Copy link
Contributor

Here x is a constant right? why should we consider listing x down in /vars?

@HirumalPriyashan
Copy link
Contributor Author

IMO const specifies that a variable value is constant. Except for the facts that const is immutable and known at the compile time(yes, those can be used to say that const is not a variable as well - so there's a bit of ambiguity), const can be used like a variable.

@DamithaSenevirathne DamithaSenevirathne mentioned this issue Jun 22, 2022
Merged
13 tasks
@DamithaSenevirathne DamithaSenevirathne mentioned this issue Jul 8, 2022
Closed
13 tasks
@DamithaSenevirathne
Copy link
Contributor

Fixed by #36653

@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@DamithaSenevirathne DamithaSenevirathne added the Reason/Regression The issue has introduced a regression. label Jul 28, 2022
@DamithaSenevirathne DamithaSenevirathne added this to the 2201.2.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamithaSenevirathne DamithaSenevirathne

Labels
Area/Shell Issues related to Ballerina Shell CLI tool Points/1 Equivalent to one day effort Points/2 Equivalent to two days effort Reason/Regression The issue has introduced a regression. Team/CompilerFETools Semantic API, Formatter, Shell Type/Bug
Projects
No open projects
Sprint 57 - Language Server & Compile...
  
Not completed
Sprint 58 - Language Server & Compile...
  
Done
Milestone
2201.2.0
4 participants
@mohanvive @dulajdilshan @DamithaSenevirathne @HirumalPriyashan