Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Marking the starting and ending bounds within a regexp #39949

Closed
pcnfernando opened this issue Mar 22, 2023 · 1 comment · Fixed by ballerina-platform/ballerina-grammar#108
Assignees
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement

Comments

@pcnfernando
Copy link
Member

Description

public function main() {
    _ = re `^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$`;
   _ = re `(ab(c))`;
}

Is it possible to mark/highlight the start and end bounds when [``]/(``) is clicked

Describe your problem(s)

No response

Describe your solution(s)

No response

Related area

-> Other Area

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@pcnfernando pcnfernando added Type/Improvement Team/LanguageServer Language Server Implementation related issues. #Compiler labels Mar 22, 2023
@IMS94
Copy link
Contributor

IMS94 commented Mar 22, 2023

This is possible. The LSP has a feature called Document Highlighting that does exactly this. But the LS hasn't implemented this method. Whatever the highlighting that you get on VSCode right now is the default highlighting by VSCode.

LS has to implement highlighting support. It means, we have to consider providing highlight support for other symbols too.

@pcnfernando pcnfernando added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. and removed Team/LanguageServer Language Server Implementation related issues. #Compiler labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants