Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error message for invalid XML string contains dependency information #40127

Closed
rdulmina opened this issue Apr 6, 2023 · 1 comment · Fixed by #40286
Closed

[Bug]: Error message for invalid XML string contains dependency information #40127

rdulmina opened this issue Apr 6, 2023 · 1 comment · Fixed by #40286
Assignees
Labels
Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Bug
Milestone

Comments

@rdulmina
Copy link
Contributor

rdulmina commented Apr 6, 2023

Description

import ballerina/io;

public function main() returns error? {
    xml x1 = check xml:fromString("<!-- comments cannot have -- in it -->");
    io:println(x1);
}

Gives error: failed to parse xml: [com.ctc.wstx.exc.WstxLazyException] String '--' not allowed in comment (missing '>'?) at [row,col {unknown-source}]: [1,10].

Currenlty to for the test cases we use "com.sun.xml.internal.stream.XMLInputFactoryImpl" and in the production we use woodstox. That's why we didn't catch this earlier. In 1.2.38 onwords we have used woodstox for testing as well hence updated the test cases in #40016

Need to fix this in SL and need to backport this to 1.2.x if possible

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Runtime

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@rdulmina rdulmina added Type/Bug Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime labels Apr 6, 2023
@Nadeeshan96 Nadeeshan96 added this to the 2201.6.0 milestone May 16, 2023
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@Nadeeshan96 Nadeeshan96 added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants