Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Add retries to Central Client #42431

Closed
xlight05 opened this issue Mar 29, 2024 · 1 comment · Fixed by #42522
Closed

[Improvement]: Add retries to Central Client #42431

xlight05 opened this issue Mar 29, 2024 · 1 comment · Fixed by #42522

Comments

@xlight05
Copy link
Contributor

Description

We are getting intermittent bal build issues from time to time due to random central call failures.

Seems like we have retryOnConnectionFailure enabled from okHTTP side. We need to evaluate on what occasions it retries and how many times it does that.

Most common failures we've observed as of now were 500, 502, 503 and connection resets for now. We need to see if retryOnConnectionFailure retries for such such cases, if not handle those separately.

If retryOnConnectionFailure doesn't work for such cases,I feel like having even a single retry should reduce these intermittent failures by a great margin.

Describe your problem(s)

No response

Describe your solution(s)

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Mar 29, 2024
@xlight05 xlight05 added Area/ProjectAPI and removed needTriage The issue has to be inspected and labeled manually labels Mar 29, 2024
@Thevakumar-Luheerathan
Copy link
Member

A similar client as the Central client is created with okHttp3 client. A service that always returns 500, 502, and 503 respectively for its resources is also created. I couldn't observe the client retrying for the resource calls mentioned above.
We will add retries manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment