Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Completion items are not properly ordered for client resource access actions #42549

Closed
nipunayf opened this issue Apr 15, 2024 · 2 comments · Fixed by #42551
Closed

[Bug]: Completion items are not properly ordered for client resource access actions #42549

nipunayf opened this issue Apr 15, 2024 · 2 comments · Fixed by #42551
Assignees
Labels
Area/Completion Issues related to Language Server Auto Completions Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Milestone

Comments

@nipunayf
Copy link
Contributor

Description

Completions are not properly ordered, as described in the proposed solution: #41636

image

Steps to Reproduce

Prompt completions for the cursor position below.

client class MyClass {
    resource function get First() {

    }

    resource function get First/[string second]() {

    }

    resource function get First/[string second]/Third() {

    }
}

function name() {
    MyClass myClass = new ();
    myClass->/<CURSOR>
}

Affected Version(s)

2201.9.0 test pack

OS, DB, other environment details and versions

OS: macOS 14.4.1 23E224
JDK: openjdk 17.0.8 2023-07-18

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@nipunayf nipunayf added Type/Bug Team/LanguageServer Language Server Implementation related issues. #Compiler Area/Completion Issues related to Language Server Auto Completions labels Apr 15, 2024
@nipunayf nipunayf self-assigned this Apr 15, 2024
@nipunayf nipunayf added this to the 2201.9.1 milestone May 10, 2024
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@nipunayf nipunayf added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label May 14, 2024
@nipunayf
Copy link
Contributor Author

Added to 2201.9.1 milestone: ballerina-platform/ballerina-release#2699

@mindula mindula modified the milestones: 2201.9.1, 2201.9.2 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Completion Issues related to Language Server Auto Completions Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Projects
Status: Done
2 participants