Make some of the Java classes in module-email proper utility classes

[vil02]

Description:

Some of the Java classes in email module, namely:

• EmailAccessUtil,
• SmtpUtil,
• EmailUtils,
• PopComplexEmailReceiveTest,
• ListenerImapReceiveTest,
• PopSimpleSecureEmailReceiveTest,
• PopSimpleEmailReceiveTest,
• SmtpSimpleSecureEmailSendTest,
• ImapSimpleSecureEmailReceiveTest,
• ImapSimpleEmailReceiveTest,
• Assert,
• SmtpSimpleSecureEmailSendWithOptionsTest,
• ListenerPopReceiveTest,
• SmtpComplexEmailSendTest,
• ImapComplexEmailReceiveTest,
• SmtpEmailSendWithOptionsTest,

appear to be utility classes (i.e. all of the members and methods are static). Generally speaking it is a good practice to:

• explicitly mark their default constructor as private (like in ModuleUtils) - because it does not make sense to have objects of such classes,
• mark such classes as final - because it does not make sense to derive any class from them.

There are benefits of doing this:

• the design is cleaner - e.g. no one will create objects of such classes,
• the coverage report will show higher/more accurate coverage (currently it is complying that instantiation of these classes is not tested).

Suggested Labels:

module/email,hacktoberfest

Suggested Assignees:

@vil02

Affected Product Version:

OS, DB, other environment details and versions:

Steps to reproduce:

Related Issues:

#4894, #4901, #4902, #4910, #4911.