Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cloud value specific validation #758

Open
xlight05 opened this issue Oct 13, 2023 · 4 comments
Open

Implement cloud value specific validation #758

xlight05 opened this issue Oct 13, 2023 · 4 comments

Comments

@xlight05
Copy link
Contributor

Description:
$Subject

As of now, we are supporting the Cloud.toml based on k8s schema. However, docker supports only a small subset of those. If the docker flag was selected, users should receive diagnostics if k8s-specific fields were selected.

This can be implemented using another schema for cloud=docker

Describe your problem(s)

Describe your solution(s)

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@Vishalk91-4
Copy link

@xlight05, could you please assign this issue to me
Could you tell me which files do i need to look into, for making changes and explain broadly on what I need to add
Thanks

@Tushar98644
Copy link

@xlight05 I would like to work on this issue

@xlight05
Copy link
Contributor Author

Hii, thanks for your interest in this specific issue.
We usually do the schema validation via a schema. You can find c2c-schema.json in the codebase. This is a custom written TOML validator which follows same json spec. However it only supports very little features of json schema spec so try to use the same syntax as the c2c-schema.json.

What you will have to do is to introduce a new file similar to c2c-schema and add the docker specific stuff there.

@keizer619
Copy link
Member

@Vishalk91-4 Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants