Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module build has warnings #297

Open
niveathika opened this issue Sep 15, 2021 · 4 comments
Open

Module build has warnings #297

niveathika opened this issue Sep 15, 2021 · 4 comments

Comments

@niveathika
Copy link
Contributor

Description:
$subject

WARNING [ballerinai/transaction/0.0.0::internal.bal:(40:43,40:105)] usage of construct 'beginTransaction((), transactionBlockId, , TWO_PHASE_COMMIT)' is deprecated
WARNING [ballerinai/transaction/0.0.0::internal.bal:(148:5,148:8)] no such documentable parameter 'err'
WARNING [ballerinai/transaction/0.0.0::service_initiator.bal:(69:5,69:5)] concurrent calls will not be made to this method since the method is not an 'isolated' method
WARNING [ballerinai/transaction/0.0.0::service_participant_2pc.bal:(34:5,34:5)] concurrent calls will not be made to this method since the method is not an 'isolated' method
WARNING [ballerinai/transaction/0.0.0::service_participant_2pc.bal:(96:5,96:5)] concurrent calls will not be made to this method since the method is not an 'isolated' method
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(54:23,54:85)] usage of construct 'beginTransaction((), transactionBlockId, , TWO_PHASE_COMMIT)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(80:36,80:87)] usage of construct 'abortTransaction(transactionId, transactionBlockId)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(132:38,132:110)] usage of construct 'registerLocalParticipant(transactionBlockId, committedFunc, abortedFunc)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(136:50,137:67)] usage of construct 'beginTransaction(txnContext.transactionId, transactionBlockId, txnContext.registerAtURL, txnContext.coordinationType)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(139:13,139:46)] usage of construct 'notifyLocalParticipantOnFailure()' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(145:27,145:65)] usage of construct 'transactionParticipantWrapper(trxFunc)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(147:13,147:46)] usage of construct 'notifyLocalParticipantOnFailure()' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(162:38,162:83)] usage of construct 'registerRemoteParticipant(transactionBlockId)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(166:50,167:67)] usage of construct 'beginTransaction(txnContext.transactionId, transactionBlockId, txnContext.registerAtURL, txnContext.coordinationType)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(169:13,169:47)] usage of construct 'notifyRemoteParticipantOnFailure()' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(187:23,187:74)] usage of construct 'abortTransaction(transactionId, transactionBlockId)' is deprecated
WARNING [ballerinai/transaction/0.0.0::transaction_block.bal:(188:5,188:53)] usage of construct 'notifyResourceManagerOnAbort(transactionBlockId)' is deprecated

This is also seen in the subsequent module builds too and is noisy.

@niveathika
Copy link
Contributor Author

This is a blocker since these are exposed to the users. This sets the precedent we don't need to fix warning as ballerina modules itself are not following it

@pcnfernando
Copy link
Member

pcnfernando commented Nov 8, 2021

Wouldn't these warning be limited to the time module is built?

@niveathika
Copy link
Contributor Author

Screenshot 2021-11-08 at 12 28 07

This log is printed the first time the transaction module is used in any bal project.

@pcnfernando
Copy link
Member

Isolated warnings are not handled in the mentioned PR. We'll be handling it separately and will use this issue to track it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants