Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a loader until the camera loads and only then enter the camera screen #69

Closed
nitzanballerine opened this issue Nov 6, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nitzanballerine
Copy link
Collaborator

Subject

Bug - The camera loads while the user is on the camera screen

Description

After entering the camera screen (where you take a picture of a document or a selfie) there are a few moments until the camera loads and appear on the screen. In the meanwhile, the user sees a grey screen.
This causes two problems:

  1. The experience looks buggy and increases anxiety.
  2. If the user clicks the camera button before the camera loads the flow will proceed to the next step, without an image taken.

Has the bug been reported before

No.

Expected Behaviour

After giving permission to use the camera and right before entering any camera screen, hold the flow on the current screen the user is in and put a loader for until the camera loads and the flow can proceed.
Once the camera has loaded, enter the camera screen.

Actual Behaviour

The user enters the camera screen and sees a blank page where the camera content should be presented, with UI on top of it.
Only once the camera has been loaded it appears on the screen.

Environment

  • All environments

Steps to Reproduce

  1. Enter the flow
  2. Choose a document to upload
  3. Approve camera permissions
  4. Enter the camera screen
  5. See the blank background
  6. Once the camera loads it will show up

Any possible solutions

Use the loader that exists in Ballerine's flow: sdks/web-sdk/src/lib/atoms/Loader/Loader.svelte
Change the text on the loader to be: "Initiating camera"

Definition of done

  1. Enter the flow
  2. Choose a document to upload
  3. Approve camera permissions
  4. See a loader
  5. Enter the camera screen when the camera is already running
@nitzanballerine nitzanballerine added bug Something isn't working good first issue Good for newcomers labels Nov 6, 2022
@TzlilSwimmer123
Copy link
Contributor

Hi @nitzanballerine I am thinking about taking this issue, how the assignment works?

@alonp99
Copy link
Collaborator

alonp99 commented Nov 29, 2022

Hey @TzlilSwimmer123, Thanks for your interest in contributing!
I'll assign this issue to you, it will be best if we talk about the details in our slack/discord community channels. we can give you all the necessary context and brainstorm about the implementation :)

@alonp99 alonp99 assigned alonp99 and TzlilSwimmer123 and unassigned alonp99 Nov 29, 2022
TzlilSwimmer123 pushed a commit that referenced this issue Dec 3, 2022
@alonp99 alonp99 closed this as completed in 9af0941 Dec 3, 2022
MihirMandviwala pushed a commit that referenced this issue Feb 12, 2024
* feat: show loader until camera loads

fix #69

* fix: add loader to Selfie and DocumentPhotoBack also

* fix(photo-steps): add loader element to all themes and photo steps

Co-authored-by: teselil <tzlil@datree.com>
Co-authored-by: Alon Peretz <alonp99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants