Support parsing multiple show variables. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 549753783Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
edrevo
reviewed
Jan 11, 2021
Comment on lines
+1733
to
+2057
| pub fn parse_identifiers(&mut self) -> Result<Vec<Ident>, ParserError> { | ||
| let mut idents = vec![]; | ||
| loop { | ||
| match self.next_token() { | ||
| Token::Word(w) => idents.push(w.to_ident()), | ||
| Token::EOF => break, | ||
| _ => {} | ||
| } | ||
| } | ||
| Ok(idents) | ||
| } |
There was a problem hiding this comment.
Is SHOW (without any variable) valid SQL? This code would return Ok(vec![]) for the SQL code SHOW, correct?
|
@francis-du could you rebase please |
Sure |
|
@francis-du I think you didn't rebase/push the rebase yet? |
Done. |
Dandandan
approved these changes
Feb 9, 2021
|
Thanks @francis-du 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing multiple show variables.
eg: