Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse floats without leading number #294

Merged
merged 5 commits into from
Feb 8, 2021

Conversation

Dandandan
Copy link
Collaborator

This fixes parsing TCPH query 6 (.01)

@andygrove

@coveralls
Copy link

coveralls commented Feb 7, 2021

Pull Request Test Coverage Report for Build 545488520

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 90.091%

Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 85.88%
src/tokenizer.rs 1 91.83%
Totals Coverage Status
Change from base Build 538263797: 0.006%
Covered Lines: 5337
Relevant Lines: 5924

💛 - Coveralls

Copy link
Collaborator

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Collaborator

@Dandandan needs rebase

@Dandandan
Copy link
Collaborator Author

@andygrove fixed

@Dandandan Dandandan merged commit f40955e into sqlparser-rs:main Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants