New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `otherProps` option #120

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sugarshin
Copy link
Contributor

sugarshin commented Jun 18, 2017

Hi,

Would you please check this.
I did it add optional otherProps prop. For example, you can add id , data-* attribute to each node.
Thanks.

@markusenglund

This comment has been minimized.

Copy link
Collaborator

markusenglund commented Aug 1, 2018

Hey, I think this is a good idea, but I'm thinking about rejecting it in favor of just letting developers pass in id attribute as a prop, even though your PR creates a more flexible api. The reason is that I can't see much of a use case for passing in any other prop than id. Could you maybe enlighten me about any such use cases?

This project hasn't been maintained for some time, so that's why no one acknowledged your PR until now. Sorry about that. I fully understand if you lost all interest in this PR.

@sugarshin

This comment has been minimized.

Copy link
Contributor Author

sugarshin commented Jan 31, 2019

@markusenglund Sorry for the late reply. It's Resolved. I will close this PR. Thank you!

@sugarshin sugarshin closed this Jan 31, 2019

@sugarshin sugarshin deleted the sugarshin:add-other-props-option branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment