Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Add otherProps option #120

Closed
wants to merge 1 commit into from

Conversation

sugarshin
Copy link
Contributor

Hi,

Would you please check this.
I did it add optional otherProps prop. For example, you can add id , data-* attribute to each node.
Thanks.

@markusenglund
Copy link
Collaborator

Hey, I think this is a good idea, but I'm thinking about rejecting it in favor of just letting developers pass in id attribute as a prop, even though your PR creates a more flexible api. The reason is that I can't see much of a use case for passing in any other prop than id. Could you maybe enlighten me about any such use cases?

This project hasn't been maintained for some time, so that's why no one acknowledged your PR until now. Sorry about that. I fully understand if you lost all interest in this PR.

@sugarshin
Copy link
Contributor Author

@markusenglund Sorry for the late reply. It's Resolved. I will close this PR. Thank you!

@sugarshin sugarshin closed this Jan 31, 2019
@sugarshin sugarshin deleted the add-other-props-option branch January 31, 2019 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants