Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-dialog doesn's expose necessary methods #139

Closed
lnkkerst opened this issue Jul 10, 2022 · 1 comment
Closed

ui-dialog doesn's expose necessary methods #139

lnkkerst opened this issue Jul 10, 2022 · 1 comment

Comments

@lnkkerst
Copy link
Contributor

Development Relevant Information:

  • BalmUI version: 10.9.2
  • Browser: Microsoft Edge Version 103.0.1264.37 (Official build) (64-bit)
  • Operating System: Gentoo

Description:

According to the defineExpose reference, ui-dialog should expose its handleAccept and handleCancel methods. but it doesn't.

Now click the CANCEL or OK button in ui-dialog-actions won't emit corresponding events.

Steps To Reproduce:

In documentation v10.9.2's Demo.
lnkkerst added a commit to lnkkerst/balm-ui that referenced this issue Jul 10, 2022
@lnkkerst
fix: ui-dialog-actions won't emit events bug (balmjs#139)
8b9efdf
elf-mouse added a commit that referenced this issue Jul 10, 2022
@elf-mouse
Merge pull request #140 from lnkkerst/10.x
5165005 
fix: ui-dialog-actions won't emit events bug (#139)
@elf-mouse
Copy link
Member

Hi @lnkkerst , It has been fixed in v10.9.3

Thank you very much for you PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elf-mouse @lnkkerst