Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-select list visibility shift inside dialog on mobile #46

Closed
jfrag opened this issue Feb 15, 2021 · 5 comments
Closed

ui-select list visibility shift inside dialog on mobile #46

jfrag opened this issue Feb 15, 2021 · 5 comments

Comments

@jfrag
Copy link
Contributor

jfrag commented Feb 15, 2021

Hi,

I made a ui-dialog with a ui-grid of ui-select.

On mobile the list of the ui-select appear in the wrong place.

<ui-dialog scrollable>
  <ui-dialog-title>Dialog title</ui-dialog-title>
  <ui-dialog-content>
    <ui-tabs>
      <ui-tab>Contrôles avant lancement</ui-tab>
      <ui-tab>Lancement</ui-tab>
    </ui-tabs>
    <ui-panels>
      <ui-panel>
        <ui-grid>
          <ui-grid-cell :columns="{default:12, tablet:8, phone:4}">
            <h3>CCP: intégrité tamis</h3>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:12, tablet:8, phone:4}">
            <ui-select :with-leading-icon="this.production.correctiveActions.datas.tamis_integrity_start != undefined" ref="tamis_integrity_start" @selected="needCorrectiveActions($event, 'tamis_integrity_start')" required fixed fullwidth :options="configurations.conformite" :defaultValue="configurations.defaultVal" default-label=" ">
              Intégrité du tamis
              <template v-if="this.production.correctiveActions.datas.tamis_integrity_start" #icon>
                <ui-select-icon @click="showCorrectiveActions($event, 'tamis_integrity_start')">flaky</ui-select-icon>
              </template>
            </ui-select>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:12, tablet:8, phone:4}">
            <ui-select required fixed fullwidth :options="configurations.boolean" :defaultValue="configurations.defaultVal" default-label=" ">
              &Eacute;lément(s) retrouvé sur le tamis
            </ui-select>
          </ui-grid-cell>
          <ui-grid-cell columns="12" v-if="production.launchBatch.tamis_element_start === '1'">
            <ui-textfield fullwidth>&Eacute;lément(s) retrouvé(s)</ui-textfield>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:12, tablet:8, phone:4}">
            <h3>Contrôle impression</h3>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:12, tablet:8, phone:4}">
            <ui-select required fixed fullwidth :options="configurations.conformite" :defaultValue="configurations.defaultVal" default-label=" ">
              Qualité/Paramétrage impression
            </ui-select>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:6, tablet:8, phone:4}">
            <h3>CCP: bon fonctionnement détecteur de métaux début de conditionnement</h3>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:4, tablet:8, phone:4}">
            <ui-select required helper-text-id="debut-ferreux" fixed fullwidth :options="configurations.conformite" :defaultValue="configurations.defaultVal" default-label=" ">
              Ferreux
            </ui-select>
            <ui-select-helper visible id="debut-ferreux">2mm - N°F414</ui-select-helper>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:4, tablet:8, phone:4}">
            <ui-select required helper-text-id="debut-nonferreux" fixed fullwidth :options="configurations.conformite" :defaultValue="configurations.defaultVal" default-label=" ">
              Non ferreux
            </ui-select>
            <ui-select-helper visible id="debut-nonferreux">2,5mm - N°B083</ui-select-helper>
          </ui-grid-cell>
          <ui-grid-cell :columns="{default:4, tablet:8, phone:4}">
            <ui-select required helper-text-id="debut-inox" fixed fullwidth :options="configurations.conformite" :defaultValue="configurations.defaultVal" default-label=" ">
              Inox
            </ui-select>
            <ui-select-helper visible id="debut-inox">2,5mm - N°S103</ui-select-helper>
          </ui-grid-cell>
        </ui-grid>
      </ui-panel>
    </ui-panels>
  </ui-dialog-content>
</ui-dialog>

Screenshot_20210215-114424

@elf-mouse
Copy link
Member

Hi jfrag,

You should remove ui-select fixed prop, try again.

@jfrag
Copy link
Contributor Author

jfrag commented Feb 18, 2021

Hi @elf-mouse

Problem solved (bad integration...)

Soory & THX

@jfrag jfrag closed this as completed Feb 18, 2021
@jfrag
Copy link
Contributor Author

jfrag commented Feb 18, 2021

I have a problem, if i remove the fixed attribute on ui-select, the overflow inside the ui-dialog don't work anymore

@jfrag jfrag reopened this Feb 18, 2021
@jfrag
Copy link
Contributor Author

jfrag commented Apr 6, 2021

I have a css fix

Don't set the fixed attr and put the css below in your stylesheet

@media (min-width:961px)  { 
  .mdc-select__menu.mdc-menu-surface--is-open-below{position:fixed !important;width:auto;}
}

Waiting for a cleaner solution

@elf-mouse
Copy link
Member

elf-mouse commented Mar 19, 2022

Hi @jfrag ,

This bug has been fixed! You can try balm-ui@10 and enjoy it :)

Thanks again~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants