Fix FP in Argument Assert (MET01) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
commented
Apr 27, 2023
| * Only interested in public methods | ||
| */ | ||
| @Override | ||
| public void visit(Method obj) { |
There was a problem hiding this comment.
Unlike the visitClassContext(ClassContext) function - which is inherited from the ByteCodeScanningDetector -, the visit(Method) function is not used for directing the run of the sawOpcode function, but to implement the main logic of the detector or to set some class variable values.
The function is inherited from BetterVisitor class and the function body is empty, so there is no need to call it.
Instead of this, I added the necessary check to the detect() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR: spotbugs#2125
Added some new testcases, fixed FP in connection with private methods in Assertation of Arguments, added license header, removed unnecessary IDE settings file.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code