fix(angular): only listen to host balChanges

baloise · Dec 12, 2022 · ecd3e2a · ecd3e2a
1 parent b444de8
commit ecd3e2a
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 8 deletions.
diff --git a/packages/components-angular/src/directives/boolean-value-accessor.ts b/packages/components-angular/src/directives/boolean-value-accessor.ts
@@ -7,7 +7,7 @@ import { ValueAccessor } from './value-accessor'
   /* tslint:disable-next-line:directive-selector */
   selector: 'bal-popover, bal-accordion',
   host: {
-    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)',
+    '(balChange)': 'handleChangeEvent($event)',
   },
   providers: [
     {

diff --git a/packages/components-angular/src/directives/checkbox-value-accessor.ts b/packages/components-angular/src/directives/checkbox-value-accessor.ts
@@ -7,7 +7,7 @@ import { ValueAccessor } from './value-accessor'
   /* tslint:disable-next-line:directive-selector */
   selector: 'bal-checkbox',
   host: {
-    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)',
+    '(balChange)': 'handleChangeEvent($event)',
   },
   providers: [
     {

diff --git a/packages/components-angular/src/directives/number-value-accessor.ts b/packages/components-angular/src/directives/number-value-accessor.ts
@@ -7,7 +7,7 @@ import { ValueAccessor } from './value-accessor'
   /* tslint:disable-next-line:directive-selector */
   selector: 'bal-number-input, bal-input-stepper',
   host: {
-    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)',
+    '(balInput)': 'handleChangeEvent($event)',
   },
   providers: [
     {

diff --git a/packages/components-angular/src/directives/select-value-accessor.ts b/packages/components-angular/src/directives/select-value-accessor.ts
@@ -7,7 +7,7 @@ import { ValueAccessor } from './value-accessor'
   /* tslint:disable-next-line:directive-selector */
   selector: 'bal-radio-group, bal-checkbox-group, bal-select, bal-datepicker, bal-tabs',
   host: {
-    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)',
+    '(balChange)': 'handleChangeEvent($event)',
   },
   providers: [
     {

diff --git a/packages/components-angular/src/directives/text-value-accessor.ts b/packages/components-angular/src/directives/text-value-accessor.ts
@@ -7,7 +7,7 @@ import { ValueAccessor } from './value-accessor'
   /* tslint:disable-next-line:directive-selector */
   selector: 'bal-input, bal-textarea, bal-input-slider',
   host: {
-    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)',
+    '(balInput)': 'handleChangeEvent($event)',
   },
   providers: [
     {

diff --git a/packages/components-angular/src/directives/value-accessor.ts b/packages/components-angular/src/directives/value-accessor.ts
@@ -20,7 +20,6 @@ export class ValueAccessor implements ControlValueAccessor {
   }
 
   handleChangeEvent(event: CustomEvent<any>) {
-    console.log('handleChangeEvent', this.el.nativeElement, this.el.nativeElement === event.target, event)
     if (this.el.nativeElement === event.target) {
       const value = event.detail
       if (value !== this.lastValue) {

diff --git a/packages/output-targets/angular/resources/control-value-accessors/value-accessor.ts b/packages/output-targets/angular/resources/control-value-accessors/value-accessor.ts
@@ -20,7 +20,6 @@ export class ValueAccessor implements ControlValueAccessor {
   }
 
   handleChangeEvent(event: CustomEvent<any>) {
-    console.log('handleChangeEvent', this.el.nativeElement, this.el.nativeElement === event.target, event)
     if (this.el.nativeElement === event.target) {
       const value = event.detail
       if (value !== this.lastValue) {

diff --git a/packages/output-targets/angular/src/generate-value-accessors.ts b/packages/output-targets/angular/src/generate-value-accessors.ts
@@ -92,4 +92,4 @@ function copyResources(config: Config, resourcesFilesToCopy: string[], directory
 const VALUE_ACCESSOR_SELECTORS = `<VALUE_ACCESSOR_SELECTORS>`
 const VALUE_ACCESSOR_EVENT = `<VALUE_ACCESSOR_EVENT>`
 const VALUE_ACCESSOR_TARGETATTR = '<VALUE_ACCESSOR_TARGETATTR>'
-const VALUE_ACCESSOR_EVENTTARGETS = `    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event.detail)'`
+const VALUE_ACCESSOR_EVENTTARGETS = `    '(<VALUE_ACCESSOR_EVENT>)': 'handleChangeEvent($event)'`