Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(bal-date): Tabnavigation get stuck in the date input #1167

Closed
1 task done
NoraKurzbein opened this issue Nov 30, 2023 · 2 comments · Fixed by #1171
Closed
1 task done

🐛 fix(bal-date): Tabnavigation get stuck in the date input #1167

NoraKurzbein opened this issue Nov 30, 2023 · 2 comments · Fixed by #1171
Assignees
Labels
🐛 bug Something isn't working

Comments

@NoraKurzbein
Copy link
Collaborator

Current Behavior

We habe a bal-date Component and two buttons (today and yesterday) to set a value on the date we do this by the following code when you click "today":

this.form?.controls[this.CLAIM_DATE].setValue(BalDateUtil.format.date.iso(new Date()));

When we set this and then navigate with tab to the date input we get stuck there. So with tab navigation you are not able to continue, if you click on the date input field, then you can use the tab navigation again.

Expected Behavior

It should be possible to navigate with tab without clicking into the field.

Steps to Reproduce

Create a button that sets the value of bal-date to today with the code above. Button must be before the bal-date, navigate just with the keyboard, use Enter to select the button and set the value, use tabnavigation to focus on the date input field, try to continue with the tab navigation

Version

14.3.0

Browsers

Chrome

Device

Desktop

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@NoraKurzbein NoraKurzbein added the 🐛 bug Something isn't working label Nov 30, 2023
@hirsch88
Copy link
Member

hirsch88 commented Dec 4, 2023

/cib

@hirsch88 hirsch88 self-assigned this Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Branch fix/issue-1167 created!

github-actions bot added a commit that referenced this issue Dec 4, 2023
hirsch88 added a commit that referenced this issue Dec 4, 2023
* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
hirsch88 added a commit that referenced this issue Dec 5, 2023
* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
hirsch88 added a commit that referenced this issue Dec 5, 2023
* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
hirsch88 added a commit that referenced this issue Dec 5, 2023
* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
hirsch88 added a commit that referenced this issue Dec 5, 2023
* Create PR for #1126

* ✨ feature: Update Stencil (#1130)

* Create PR for #1128

* chore: update stencil

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 💥 breaking: remove Deprecated Mode Style (#1139)

* Create PR for #1129

* breaking: remove deprecated mode style

* chore: fix lint issues

* chore: remove deprecated bal-body class

* chore: format files

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update Error Component (#1140)

* Create PR for #1131

* chore: improve error component

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update value accessor (#1141)

* Create PR for #1132

* chore: improve value accessors

* chore: update value accessors

* chore: add missing icon

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 💥 breaking: Change config default to set invalid auto (#1145)

* Create PR for #1133

* Create PR for #1126

* ✨ feature: Update Stencil (#1130)

* Create PR for #1128

* chore: update stencil

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 💥 breaking: remove Deprecated Mode Style (#1139)

* Create PR for #1129

* breaking: remove deprecated mode style

* chore: fix lint issues

* chore: remove deprecated bal-body class

* chore: format files

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update Error Component (#1140)

* Create PR for #1131

* chore: improve error component

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update value accessor (#1141)

* Create PR for #1132

* chore: improve value accessors

* chore: update value accessors

* chore: add missing icon

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* Create PR for #1126

* breaking: setInvalid is not by default enabled

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: Add const like breakpoints & breakpointSubject to the config + platformhelpers (#1146)

* Create PR for #1134

* Create PR for #1133

* Create PR for #1126

* ✨ feature: Update Stencil (#1130)

* Create PR for #1128

* chore: update stencil

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 💥 breaking: remove Deprecated Mode Style (#1139)

* Create PR for #1129

* breaking: remove deprecated mode style

* chore: fix lint issues

* chore: remove deprecated bal-body class

* chore: format files

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update Error Component (#1140)

* Create PR for #1131

* chore: improve error component

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update value accessor (#1141)

* Create PR for #1132

* chore: improve value accessors

* chore: update value accessors

* chore: add missing icon

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* Create PR for #1126

* breaking: setInvalid is not by default enabled

* chore: remove default import to reduce side effects

* chore: update default config object

* chore: add platform helpers

* Create PR for #1126

* 💥 breaking: remove Deprecated Mode Style (#1139)

* Create PR for #1129

* breaking: remove deprecated mode style

* chore: fix lint issues

* chore: remove deprecated bal-body class

* chore: format files

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore: update value accessor (#1141)

* Create PR for #1132

* chore: improve value accessors

* chore: update value accessors

* chore: add missing icon

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* chore: format code

* chore: fix lint issue

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* chore: add new ng proxy structure (#1148)

* chore: add model to angular test (#1149)

* chore: rename angular path to v16 (#1150)

* chore: rename angular path to v16

* chore: rename ci steps

* chore: adjust output

* chore: adjust output

* chore: adjust output

* chore: adjust output

* chore: adjust output

* chore: adjust output

* chore: adjust output

* Chore/new-output-ng-17 (#1159)

* chore: adjust ng apps

* chore: add v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: update ci with v17

* chore: copy proxies

* chore: add missing links

* chore: link testing lib

* chore: link testing lib

* chore: link testing lib

* chore: link testing lib

* chore: link testing lib

* chore: link testing lib

* chore: link testing lib

* chore: hide icons

* chore: combine links

* chore: combine links

* chore: add matrix

* chore: add fonts

* chore: add v17

* chore: add v17

* chore: add v17

* chore: update to v17

* chore: use css

* chore: sync lock files

* chore: add new component output (#1163)

* Chore/v17-ng (#1164)

* chore: add new ng output

* chore: v16 running again

* chore: improve imports

* chore: update ci

* chore: change zip path

* chore: change zip path 2

* chore: change zip path 3

* chore: fix event name for angular value accessors

* chore: v17 path issue

* chore: install deps for ng tests

* chore: fix event listeners for angular

* chore: remove polyfills

* chore: add changeset and update angular json

* chore: add v17 vite

* chore: improve import in angular apps

* chore: adjust builder for ng apps

* chore: adjust angular paths

* chore: adjust angular package paths

* chore: adjust angular package paths

* chore: adjust angular package paths 2

* feat(angular): enable standalone first draft (#1170)

* feat(angular): enable standalone first draft

* chore: update package.json

* feat(angular): add standalone solution

* chore: add changeset

* chore: adjust bundle

* chore: improve package.json to reduce side effects

* chore: update package.lock

* chore: add missing build for standalone

* chore: add missing build for standalone

* chore: add bal-doc-app to e2e tests

* chore: add docs

* chore: add as const for bundles

* 🐛 fix(): resolve logo animation issue by updating Lottie import (#1168)

chore(): resolve logo animation issue by updating Lottie import

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>

* 🐛 fix(bal-date): Tabnavigation get stuck in the date input (#1171)

* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🔧 chore(): improve docs (#1118)

* chore(): improve docs

* chore(): improve docs

* chore(): refactor

---------

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>

* 🐛 fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus (#1177)

* fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus

* chore: add missing select

---------

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* ✨ feat(form): horizontal layout for label and controls (#1169)

* Create PR for #1160

* chore(): horizontal align field label and input

* chore(): improve styling and add visual tests

* chore(): trigger build

* chore(): trigger build

* chore(): trigger build

* chore(): update base images

* feat(bal-field): Introduce 'horizontal' prop for aligning label and input side by side in Field component, with message displayed below

* chore(): update base images

* chore(): refactor

* chore(): align field control to the end when label is too long

* chore(): update base images

* chore(): refactor

* chore(): refactor

* chore(): refactor

* chore(): separate horizontal test

* chore(): add head element

* chore(): format

* chore(): update base images

* chore: trigger build

---------

Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com>
Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* Version Packages (#1172)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(): update lock file

* chore(): update lock file

* 🐛 fix(): resolve logo animation issue by updating Lottie import (#1168)

chore(): resolve logo animation issue by updating Lottie import

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>

* 🐛 fix(bal-date): Tabnavigation get stuck in the date input (#1171)

* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🐛 fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus (#1177)

* fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus

* chore: add missing select

---------

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* ✨ feat(form): horizontal layout for label and controls (#1169)

* Create PR for #1160

* chore(): horizontal align field label and input

* chore(): improve styling and add visual tests

* chore(): trigger build

* chore(): trigger build

* chore(): trigger build

* chore(): update base images

* feat(bal-field): Introduce 'horizontal' prop for aligning label and input side by side in Field component, with message displayed below

* chore(): update base images

* chore(): refactor

* chore(): align field control to the end when label is too long

* chore(): update base images

* chore(): refactor

* chore(): refactor

* chore(): refactor

* chore(): separate horizontal test

* chore(): add head element

* chore(): format

* chore(): update base images

* chore: trigger build

---------

Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com>
Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* Version Packages (#1172)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(): update lock file

* 🐛 fix(): resolve logo animation issue by updating Lottie import (#1168)

chore(): resolve logo animation issue by updating Lottie import

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>

* 🐛 fix(bal-date): Tabnavigation get stuck in the date input (#1171)

* Create PR for #1167

* fix(input-date): tab navigation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* 🐛 fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus (#1177)

* fix(): Replace timeout with await waitAfterIdleCallback in inputSetFocus

* chore: add missing select

---------

Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* ✨ feat(form): horizontal layout for label and controls (#1169)

* Create PR for #1160

* chore(): horizontal align field label and input

* chore(): improve styling and add visual tests

* chore(): trigger build

* chore(): trigger build

* chore(): trigger build

* chore(): update base images

* feat(bal-field): Introduce 'horizontal' prop for aligning label and input side by side in Field component, with message displayed below

* chore(): update base images

* chore(): refactor

* chore(): align field control to the end when label is too long

* chore(): update base images

* chore(): refactor

* chore(): refactor

* chore(): refactor

* chore(): separate horizontal test

* chore(): add head element

* chore(): format

* chore(): update base images

* chore: trigger build

---------

Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com>
Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>

* Version Packages (#1172)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: update lock file

---------

Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com>
Co-authored-by: Mladen Planinicic <mladen.planinicic@baloise.ch>
Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants