-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#82: ClassCastException after Plugin update on DC #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BandanaManager.init() is called initially - removes workaround with clone - serialization of Signature to JSON using GSON
arburk
approved these changes
Feb 6, 2022
private void save(Signature signature) { | ||
if (signature.hasMissingSignatures()) | ||
bandanaManager.setValue(GLOBAL_CONTEXT, signature.getKey(), signature); | ||
if (value instanceof String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
c5c3ba4
to
ab6f479
Compare
Tests to be performed before release:
After Release
|
ae91b9d
to
be8de5f
Compare
be8de5f
to
44b4ea4
Compare
debuggen with: docker run -e JVM_SUPPORT_RECOMMENDED_ARGS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005" -v confluenceVolume:/var/atlassian/application-data/confluence --name=confluence -d -p 5005:5005 -p 8090:8090 -p 8091:8091 atlassian/confluence-server:latest
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides other posts regarding this issue in the "Atlassian Developer Community" this one summarizes it quite well:
and further
Following that, I've added this PR that should address this issue in a self healing way. Meaning: The issue might occur again after an environment gets this patch (and requires a manual plugin cache reset / reboot once again), but should be fixed for all following updates.