fix(CredentialsHelper): Add single quotes around username/password to…

… support special characters in credentials (#171) Co-authored-by: Nikolas Philips <nikolas.philips@baloise.com>
baloise · Feb 18, 2022 · bd2ad19 · bd2ad19
1 parent b5833f6
commit bd2ad19
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/gitopscli/git_api/git_repo.py b/gitopscli/git_api/git_repo.py
@@ -109,7 +109,7 @@ def __create_credentials_file(self, username: str, password: str) -> str:
         file_path = f"{self.__tmp_dir}/credentials.sh"
         with open(file_path, "w") as text_file:
             text_file.write("#!/bin/sh\n")
-            text_file.write(f"echo username={username}\n")
-            text_file.write(f"echo password={password}\n")
+            text_file.write(f"echo username='{username}'\n")
+            text_file.write(f"echo password='{password}'\n")
         os.chmod(file_path, 0o700)
         return file_path
diff --git a/tests/git_api/test_git_repo.py b/tests/git_api/test_git_repo.py
@@ -144,8 +144,8 @@ def test_clone_with_credentials(self, logging_mock):
             self.assertEqual(
                 """\
 #!/bin/sh
-echo username=User
-echo password=Pass
+echo username='User'
+echo password='Pass'
 """,
                 credentials_file,
             )