Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix black formatter by pinning click dependency version #176

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

christiansiegel
Copy link
Member

Our code formatter black uses sub-dependency click. The minor release of click from 8.0.4 to 8.1.0 breaks black. See also psf/black#2964

Quick workaround: Pin click to an older version.

Longterm fix: Upgrade black to the most recent version. However, this changes the formatting in a few places. That's why I wanted to wait until the other PRs are merged to prevent merge conflicts.

@christiansiegel christiansiegel merged commit 5c80376 into master Mar 31, 2022
@joachimprinzbach joachimprinzbach deleted the fix/black-click branch March 31, 2022 10:48
@baopso
Copy link

baopso commented Apr 7, 2022

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@baopso baopso added the released label Apr 7, 2022
christiansiegel added a commit that referenced this pull request Apr 15, 2022
christiansiegel added a commit that referenced this pull request Apr 16, 2022
@baopso
Copy link

baopso commented May 9, 2022

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants