Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-formatting): correct missing coversion type / wrong conversion flag for info log line #206

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

renat1sakenov
Copy link
Contributor

Seems to be the cause of

INFO __sync_apps: Found 6 app(s) in apps repository: ....., cop-3299-test, cop-3299-prod, ....
07:49:02  --- Logging error ---
07:49:02  Traceback (most recent call last):
07:49:02    File "/usr/local/lib/python3.10/logging/__init__.py", line 1100, in emit
07:49:02      msg = self.format(record)
07:49:02    File "/usr/local/lib/python3.10/logging/__init__.py", line 943, in format
07:49:02      return fmt.format(record)
07:49:02    File "/usr/local/lib/python3.10/logging/__init__.py", line 678, in format
07:49:02      record.message = record.getMessage()
07:49:02    File "/usr/local/lib/python3.10/logging/__init__.py", line 368, in getMessage
07:49:02      msg = msg % self.args
07:49:02  TypeError: %i format: a real number is required, not str
07:49:02  Call stack:
07:49:02    File "/opt/venv/bin/gitopscli", line 33, in <module>
07:49:02      sys.exit(load_entry_point('gitopscli==5.7.0', 'console_scripts', 'gitopscli')())
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/__main__.py", line 14, in main
07:49:02      command.execute()
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/commands/sync_apps.py", line 27, in execute
07:49:02      _sync_apps_command(self.__args)
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/commands/sync_apps.py", line 35, in _sync_apps_command
07:49:02      __sync_apps(team_config_git_repo, root_config_git_repo, args.git_user, args.git_email)
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/commands/sync_apps.py", line 53, in __sync_apps
07:49:02      root_repo_tenant.merge_applications(tenant_from_repo)
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/appconfig_api/app_tenant_config.py", line 35, in merge_applications
07:49:02      self.__add_new_applications(desired_apps)
07:49:02    File "/opt/venv/lib/python3.10/site-packages/gitopscli/appconfig_api/app_tenant_config.py", line 67, in __add_new_applications
07:49:02      logging.info("Adding % in %s applications", desired_app_name, self.file_path)
07:49:02  Message: 'Adding % in %s applications'
07:49:02  Arguments: ('cop-3299-prod', '/tmp/gitopscli/ce83d9fe-2031-4dcc-80b9-9c422e4daee5/repo/apps/......yaml')

to reproduce:

python3
>>> var1="output1"
>>> var2="output2"
>>> print("printing %s in %s" % (var1,var2))
printing output1 in output2
>>> print("printing % in %s" % (var1,var2))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: %i format: a real number is required, not str

See also https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting

Copy link
Member

@christiansiegel christiansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@christiansiegel christiansiegel merged commit 41f3bd1 into baloise:master Aug 14, 2023
1 check passed
@github-actions
Copy link

🎉 This PR is included in version 5.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants