-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong field name in login() method #47
Comments
Could you please provide a sample case / test-case showing a scenario where the current login fails and subsequently works (using your modification)? I do currently use the tool as is for login, but it works with RocketChat 2.3! |
It does not work with RocketChat 3.3 |
I just tested against 3.3 and it seems to work. What is your usage scenario? |
I tried with To make it work, I checked out the project and made the named change and again used I guess you agree, that the Rocket.Chat API |
so you tried the maven version, not the current master in this repository? The version distributed via maven is quite old. It does not matter whether we agree on the documentation - first a test must fail - to this end I updated the build to test against 3.3.3 which does build correctly. Please test your code using the current master as served in this repo, you could also share a snipped of what is not working for you, to include as additional test. |
Well, I did not write clear enough. After failing with maven version, I cloned current master and debugged and verified the failure. Then I changed the parameter name to my test code is a 2 liner:
|
I just tested this current code against my running productive 3.3.3 installation with
and it works without a problem. |
So the point might very well be on the other end. My Rocket.Chat installation is a new installation of Version 33.0 from Scratch using the official docker image. |
After update to Rocket.Chat V3.3.3 I still observer the same. I reduced the client part to a setup in PostMan, still the same. Using |
Both |
The method
RocketChatClientCallBuilder
.login
inmaster
branch is usingusername
field to set the username value but the API is expectinguser
instead.By using
username
the response is always401 Unauthorized
(other endpoints are already acceptingusername
so my understanding is this field name should be standardised).The text was updated successfully, but these errors were encountered: