Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: plugin reacts to change of user settings #5

Closed
Balvald opened this issue Nov 25, 2022 · 1 comment · Fixed by #7
Closed

Feature: plugin reacts to change of user settings #5

Balvald opened this issue Nov 25, 2022 · 1 comment · Fixed by #7
Assignees
@Balvald
Labels
enhancement New feature or request
Milestone
v0.1.2

Comments

@Balvald
Copy link
Owner

Balvald commented Nov 25, 2022

As of now the plugin still needs to be restarted for the changed plugin settings to take effect.

This is annoying because any single change (box tick) in the plugins' settings needs atleast a restart of EDMC to take effect.

Implement a way to dynamically add and remove widgets without the need to restart EDMC everytime.

Check https://github.com/EDCD/EDMarketConnector/blob/main/PLUGINS.md#display and https://github.com/EDCD/EDMarketConnector/blob/main/PLUGINS.md#avoiding-potential-pitfalls
@Balvald Balvald added the enhancement New feature or request label Nov 25, 2022
@Balvald Balvald added this to the v 0.1.2 milestone Nov 25, 2022
@Balvald Balvald self-assigned this Nov 25, 2022
@Balvald
Copy link
Owner Author

Balvald commented Nov 25, 2022

Is implemented and working on dev branch with bbb32b9

@Balvald Balvald closed this as completed Nov 25, 2022
@Balvald Balvald mentioned this issue Dec 1, 2022
Merged
@Balvald Balvald linked a pull request Dec 5, 2022 that will close this issue
Pull of biodata and unsold profit tracking #7
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.2
Development

Successfully merging a pull request may close this issue.

Pull of biodata and unsold profit tracking Balvald/ArtemisScannerTracker
1 participant
@Balvald