ensure nil params don't get through

balvig · Jan 17, 2015 · 9dce5de · 9dce5de
1 parent 10f7a6e
commit 9dce5de
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/lib/spyke/path.rb b/lib/spyke/path.rb
@@ -43,7 +43,13 @@ def validate_required_params!
       end
 
       def missing_required_params
-        required_params - @params.keys
+        required_params - params_with_values
+      end
+
+      def params_with_values
+        @params.map do |key, value|
+          key if value.present?
+        end.compact
       end
 
       def required_params

diff --git a/lib/spyke/version.rb b/lib/spyke/version.rb
@@ -1,3 +1,3 @@
 module Spyke
-  VERSION = '1.7.0'
+  VERSION = '1.7.1'
 end
diff --git a/test/relation_test.rb b/test/relation_test.rb
@@ -124,5 +124,11 @@ def test_namespaced_model
       assert_requested tip_endpoint
       assert_requested likes_endpoint
     end
+
+    def test_path_validation
+      assert_raises Spyke::InvalidPathError do
+        Recipe.new.groups.to_a
+      end
+    end
   end
 end