Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black style check on lint #220

Merged
merged 6 commits into from Jul 4, 2020
Merged

Add black style check on lint #220

merged 6 commits into from Jul 4, 2020

Conversation

camenpihor
Copy link
Contributor

@camenpihor camenpihor commented Jul 3, 2020

fix #221

Changes

  1. I noticed that we say the library uses the black code style in the readme, and that the code is already black-ified so I added a black check to the lint script
    • I excluded tests from the check, because of personal preference, but happy to run the black checker on the tests too, if you want? (although they don't pass right now)
    • I think the code was already set to line length 100, so I used that, but happy for this to be whatever (I use 90 personally)
  2. Call the lint script from the test script

@camenpihor camenpihor self-assigned this Jul 3, 2020
Base automatically changed from some-linting to master July 3, 2020 20:29
@canyon289
Copy link
Collaborator

canyon289 commented Jul 3, 2020

This just installs black. Is it intended that a check will be performed as well?

Nevermind: I see it, for some reason github didn't load full diff when I checked :)

scripts/lint.sh Outdated Show resolved Hide resolved
@camenpihor camenpihor requested a review from canyon289 July 3, 2020 21:28
Copy link
Collaborator

@canyon289 canyon289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id say include tests because inevitably someone will end up running black on tests and itll obscure the git blame path, and also because why not, but not super strongly opinionated about it

scripts/lint.sh Outdated Show resolved Hide resolved
@camenpihor
Copy link
Contributor Author

Thanks for the review! I'll merge after tests pass

@camenpihor camenpihor merged commit a50b66c into master Jul 4, 2020
@camenpihor camenpihor deleted the black branch July 4, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let Travis check for black format.
2 participants