-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beta Regression Example #442
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @tjburch Thanks for this great contribution! A single example would have been sufficient, but this notebook having three examples ranging from very simple to more complex is amazing. I've also left some comments trying to answer your questions. Let me know if I can help with anything else :) |
Awesome! Very much appreciate you taking a look over it. I'll get the ball rolling on those fixes. |
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 31 31
Lines 2425 2425
=======================================
Hits 2168 2168
Misses 257 257 Continue to review full report at Codecov.
|
Just fixed up those changes, I also tightened up the language a bit in parts. If there's further comments that I can implement, let me know! |
I'm glad you are one step ahead of me and added your name on the top of the notebook :). I'll try to review more in-depth tomorrow. Thanks again for the contribution! |
@aloctavodia if you are happy with the changes, feel free to merge |
Thanks @tjburch, this is a great example. |
Issue #369 requested a beta regression example. I've been playing around with that and putting together a sketch of one. This PR adds that notebook. There's a couple of problems within the example that need some comments, I'll notate these. If there's other suggestions where to go with it as well, I'm happy to adapt it. Right now it's heavy on two toy examples, and light on one real-world example reusing the baseball dataset.