Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beta Regression Example #442

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Add Beta Regression Example #442

merged 5 commits into from
Jan 21, 2022

Conversation

tjburch
Copy link
Contributor

@tjburch tjburch commented Jan 17, 2022

Issue #369 requested a beta regression example. I've been playing around with that and putting together a sketch of one. This PR adds that notebook. There's a couple of problems within the example that need some comments, I'll notate these. If there's other suggestions where to go with it as well, I'm happy to adapt it. Right now it's heavy on two toy examples, and light on one real-world example reusing the baseball dataset.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tomicapretto
Copy link
Collaborator

Hi @tjburch

Thanks for this great contribution! A single example would have been sufficient, but this notebook having three examples ranging from very simple to more complex is amazing.

I've also left some comments trying to answer your questions. Let me know if I can help with anything else :)

@tjburch
Copy link
Contributor Author

tjburch commented Jan 17, 2022

Awesome! Very much appreciate you taking a look over it. I'll get the ball rolling on those fixes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #442 (9d75d3d) into main (7d5a83f) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d75d3d differs from pull request most recent head be6f2f9. Consider uploading reports for the commit be6f2f9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          31       31           
  Lines        2425     2425           
=======================================
  Hits         2168     2168           
  Misses        257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5a83f...be6f2f9. Read the comment docs.

@tjburch
Copy link
Contributor Author

tjburch commented Jan 18, 2022

Just fixed up those changes, I also tightened up the language a bit in parts. If there's further comments that I can implement, let me know!

@tomicapretto
Copy link
Collaborator

I'm glad you are one step ahead of me and added your name on the top of the notebook :).

I'll try to review more in-depth tomorrow.

Thanks again for the contribution!

@tomicapretto
Copy link
Collaborator

@aloctavodia if you are happy with the changes, feel free to merge

@aloctavodia aloctavodia merged commit 363cb3b into bambinos:main Jan 21, 2022
@aloctavodia
Copy link
Collaborator

Thanks @tjburch, this is a great example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants