Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: fix typos and clear up wording #462

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Examples: fix typos and clear up wording #462

merged 6 commits into from
Mar 2, 2022

Conversation

yannmclatchie
Copy link
Contributor

Hi! Please find in this small PR some minor improvements to the examples and docs, mostly rewording for clarity and fixing typos. I hope this helps!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -514,7 +514,7 @@
"cell_type": "markdown",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh this is controversial! :-)


Reply via ReviewNB

@aloctavodia
Copy link
Collaborator

Thanks @yannmclatchie LGTM!

@aloctavodia aloctavodia changed the title Minor improvements to examples Examples: fix typos and clear up wording Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #462 (d5ce090) into main (05ece83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          31       31           
  Lines        2491     2491           
=======================================
  Hits         2223     2223           
  Misses        268      268           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ece83...d5ce090. Read the comment docs.

@tomicapretto
Copy link
Collaborator

Hi @yannmclatchie, thanks for this contribution! It looks good! I'm merging the changes.

@tomicapretto tomicapretto merged commit 2d3bf85 into bambinos:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants