Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vonmises example #465

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Add vonmises example #465

merged 3 commits into from
Mar 21, 2022

Conversation

aloctavodia
Copy link
Collaborator

Closes #454

Also need to update the table with supported families and link functions.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022 •
edited

Codecov Report

Merging #465 (a55cabe) into main (17fc49c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a55cabe differs from pull request most recent head 767d9a1. Consider uploading reports for the commit 767d9a1 to get more accurate results

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   89.24%   89.25%   +0.01%     
==========================================
  Files          31       31              
  Lines        2491     2494       +3     
==========================================
+ Hits         2223     2226       +3     
  Misses        268      268
Impacted Files Coverage Δ
bambi/priors/scaler_default.py 95.58% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fc49c...767d9a1. Read the comment docs.

@tomicapretto
Copy link
Collaborator

Can we upload the periwinkles.csv file to Figshare and use it with bmb.load_data()? I also think there are other datasets in docs/notebooks/data that we could remove, but let's leave that for another PR.

I could upload the file to Figshare if you want.

@aloctavodia
Copy link
Collaborator Author

sure, let's do that.

@aloctavodia aloctavodia changed the title [WIP] add vonmises example Add vonmises example Mar 17, 2022
tomicapretto
tomicapretto requested changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@tomicapretto tomicapretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here is to remove the ANOVA notebook because it's not working right now.

docs/examples.rst Outdated Show resolved Hide resolved
docs/notebooks/data/periwinkles.csv Show resolved Hide resolved
tomicapretto
tomicapretto reviewed Mar 21, 2022
View reviewed changes
bambi/data/datasets.py
@@ -177,8 +184,8 @@ def load_data(dataset=None, data_home=None):
checksum = _sha256(file_path)
if datafile.checksum != checksum:
raise IOError(
"{file_path} has an SHA256 checksum ({checksum}) differing from expected "
"({datafile.checksum}), file may be corrupted. Run `bambi.clear_data_home()` "
f"{file_path} has an SHA256 checksum ({checksum}) differing from expected "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@tomicapretto tomicapretto merged commit d8f77f2 into bambinos:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomicapretto tomicapretto tomicapretto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VonMises example
3 participants
@aloctavodia @codecov-commenter @tomicapretto