Use dims instead of coords #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
==========================================
- Coverage 90.47% 90.32% -0.16%
==========================================
Files 29 29
Lines 2320 2459 +139
==========================================
+ Hits 2099 2221 +122
- Misses 221 238 +17
Continue to review full report at Codecov.
|
aloctavodia
added a commit
that referenced
this pull request
Jun 1, 2022
* Extract args (#493) * fix multinomial family with group-specific terms * Refactorize how we compute predictions * remove unintentional brms file and black * remove typo from test * rerun categorical regression * add shooter data again * Update coords of terms * Fixed stack order in predict for categorical group specific terms and message label in bernoulli family * [no ci] docstring * Add utils to extract labels when we use multinomial family. Also add 'c' function which was not added before. * Add coordinate for predictions in multinomial model * Use dims instead of coords (#499) * Update to use dims instead of coords. Also rename group-specific dims * update examples that used coords * Update changelog * Fix how we look for dims. This should fix tests * Fix typos (#501) * Don't modify original dataset (#502) * Don't modify original dataset * update changelog * black and lint * [no ci] update changelog * [no ci] minor updates to CONTRIBUTING * [no ci] update docs conf * Remove draws argument from model predict (#504) * Prepare 0.8.0 release (#505) * Prepare release (update formulae reqs) * Update changelog * Update publish-docs-release.yml * Update publish-docs-release.yml * Add workflow_dispatch to .yml to run manually * merge changes * update backend to PyMC v4 Co-authored-by: Tomás Capretto <tomicapretto@gmail.com> Co-authored-by: Hector Munoz <23343812+hectormz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized we were using the term
coordsfor things that are actuallydimsin thexarrayworld.This PR updates several places where we were wrongly using
coords.On top of that, I renamed the dimensions we use for group-specific terms:
factor + "_coord_group_factor"is nowfactor + "__factor_dim"expr + "_coord_group_expr"is nowexpr + "__expr_dim"which are clearer, shorter, and safer.